Add linter to check for keywords in the package name#281
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #281 +/- ##
==========================================
+ Coverage 72.15% 72.22% +0.06%
==========================================
Files 120 121 +1
Lines 5413 5425 +12
==========================================
+ Hits 3906 3918 +12
Misses 1135 1135
Partials 372 372
Continue to review full report at Codecov.
|
|
@peter-edge, had you considered adding a larger catalog of keywords to the lint? We recently had an issue where some We're planning to add checks in CI against the keyword lists for Java, C, C++, Go, and JavaScript. We also use Rust and Python, but Rust's recent addition of 'raw identifiers' lets it bypass the issue, and Python has a workaround using Of course, the trade-off is the linter having to enumerate many languages' keywords, which might be an unjustifiable maintenance burden. UPDATE: Realized I neglected to ask if you had also considered keyword checks for fields in addition to the package name. |
|
I don't think we're going to extend this - the list would get too exhaustive. The current keyword set is meant to cover the most common cases, and as you mentioned, maintenance would be difficult. Additionally, we'd want such a linter to be part of a lint group, but adding linters (or keywords to the existing keyword linting) would be a breaking change. |
Re: #265.