Update to use API token, instead of API key#2
Update to use API token, instead of API key#2ywei2017 wants to merge 1 commit intoubidots:masterfrom
Conversation
d4vsanchez
left a comment
There was a problem hiding this comment.
Hi @ywei2017,
Thanks for your contribution.
Unfortunately I'm not able to merge this PR for the following reasons:
-
Even though we've basically stopped using the API Key for our public examples and kept using the tokens. This PR will change the way the whole
Client.auth()method works by receiving the token instead of receiving the API Key. We could do that, but the version should be bumped to a major instead of a patch, as it currently has been done in this PR. -
It actually breaks the tests of some methods that depends on calling the
Client.auth()method and getting the token after authenticating with the/api/v1.6/auth/tokenendpoint.
|
@d4vsanchez , thanks for the quick feedback. I was struggling with the
I also agree that moving away from the What would you suggest as next step? I did try to run some of the tests, but I got errors as well. If you can let me know the proper setting to run the tests, I can work more on it to make sure the tests are passing. Thanks |
Updated the endpoint URL, and use API token, instead of API Key.