fix(electron): drop $HOME default from media roots#75
Merged
Conversation
Closes #47. Default to the project working directory plus any of ~/Videos, ~/Movies, ~/Music, ~/Pictures, ~/Documents that actually exist, rather than exposing the entire user home directory through the backend's /file, /video, /audio handlers. FRAMESCRIPT_MEDIA_ROOTS still wins when set. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FRAMESCRIPT_MEDIA_ROOTSto the project working directory plus a curated set of~/Videos,~/Movies,~/Music,~/Pictures,~/Documents(only the ones that actually exist) instead of the whole$HOME.FRAMESCRIPT_MEDIA_ROOTSexplicitly.Closes #47.
Test plan
npm run typechecknpm run lint~/Videosand the project root works in dev.🤖 Generated with Claude Code