ci(rust): run cargo clippy --deny warnings and cargo test in CI#77
Open
ubugeeei wants to merge 1 commit into
Open
ci(rust): run cargo clippy --deny warnings and cargo test in CI#77ubugeeei wants to merge 1 commit into
ubugeeei wants to merge 1 commit into
Conversation
Closes #49 and #50. The rust matrix job now installs clippy alongside the stable toolchain and runs: - cargo clippy --all-targets -- -D warnings - cargo test --all-targets Also fixes the four collapsible-if lints and the too-many-arguments lint that surface with clippy 1.95 on the render crate so the new gate is green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo clippy --all-targets -- -D warningsandcargo test --all-targetsto the existing rust matrix job.collapsible_iflints and thetoo_many_argumentslint that newer clippy reports against the render crate so the new gate is green.Closes #49 and #50.
Test plan
cargo clippy --all-targets -- -D warnings(both crates, locally on clippy 1.95)cargo test --all-targets(both crates)🤖 Generated with Claude Code