Skip to content

Fix: hide menu options until user has logged in#54

Merged
pieterlukasse merged 1 commit into
2.15.0-DEVfrom
fix/disable_menu_prior_to_login
Jul 1, 2024
Merged

Fix: hide menu options until user has logged in#54
pieterlukasse merged 1 commit into
2.15.0-DEVfrom
fix/disable_menu_prior_to_login

Conversation

@pieterlukasse
Copy link
Copy Markdown

@pieterlukasse pieterlukasse commented Jun 27, 2024

Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/VADC-1221

New Features

  • menu options are hidden until user has logged in. This fixes an issue related to missing "teamproject" info and subsequent (transient) login flow error and need to refresh the page

@pieterlukasse pieterlukasse requested a review from tianj7 June 27, 2024 13:11
@pieterlukasse pieterlukasse force-pushed the fix/disable_menu_prior_to_login branch from dae34d4 to c9eed2a Compare June 27, 2024 13:21
@pieterlukasse pieterlukasse force-pushed the fix/disable_menu_prior_to_login branch from c9eed2a to 97aec35 Compare June 27, 2024 13:29
@pieterlukasse
Copy link
Copy Markdown
Author

replaced by uc-cdis/data-portal#1561

@pieterlukasse
Copy link
Copy Markdown
Author

reopening, as there seems to be a use case where this is useful.

@pieterlukasse pieterlukasse reopened this Jun 28, 2024
@pieterlukasse pieterlukasse merged commit 5ec7d76 into 2.15.0-DEV Jul 1, 2024
@pieterlukasse pieterlukasse deleted the fix/disable_menu_prior_to_login branch July 1, 2024 15:12
@pieterlukasse
Copy link
Copy Markdown
Author

upstream PR: OHDSI#3004

@pieterlukasse
Copy link
Copy Markdown
Author

addressed upstream PR feedback here: c13024b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants