[HOLD] move backoff settings, send email, and create client to config#1181
Closed
AlbertSnows wants to merge 13 commits into
Closed
[HOLD] move backoff settings, send email, and create client to config#1181AlbertSnows wants to merge 13 commits into
AlbertSnows wants to merge 13 commits into
Conversation
fixing config import removing duplicate property fix unused imports update lock file fix movement
commenting out hmac
|
Please find the ci env pod logs here |
Contributor
Author
|
closing for the rework here -> #1209 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR on hold until #1182 is merged
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PXP-11392
This PR moves config properties and functions out of utils into config. Utils should be low-level, and thus not reference other namespaces for sake of not inducing circular dependencies.
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes