Skip to content

gen3 run: propagate exit code #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulineribeyre merged 2 commits into from
Apr 17, 2026
Merged

gen3 run: propagate exit code #297

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07bc6a3
gen3 run: propagate exit code
paulineribeyre Apr 17, 2026
286f19c
fix test
paulineribeyre Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion gen3/tools/wrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ def run_command(self):
f"Running the command {self.command_args} with gen3 access token in environment variable"
)
try:
subprocess.run(cmd, stderr=subprocess.STDOUT)
subprocess.run(cmd, stderr=subprocess.STDOUT, check=True)
except Exception as e:
logger.error(f"ERROR while running '{cmd}':", e)
raise
4 changes: 3 additions & 1 deletion tests/test_wrap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ def test_gen3_wrap_valid_auth(mock_gen3_auth):
with patch("gen3.tools.wrap.subprocess.run") as mock_subprocess_run:
wrapper_obj = Gen3Wrap(mock_gen3_auth, test_command_args)
wrapper_obj.run_command()
mock_subprocess_run.assert_called_once_with(list(test_command_args), stderr=-2)
mock_subprocess_run.assert_called_once_with(
list(test_command_args), stderr=-2, check=True
)


@patch.object(Gen3Auth, "get_access_token", MagicMock(side_effect=Gen3AuthError()))
Expand Down
Loading