MIDRC-749 Add disk space configuration to AWS batch nodes#123
Conversation
Please find the detailed integration test report here Please find the ci env pod logs here |
jawadqur
changed the title
Please find the detailed integration test report here Please find the ci env pod logs here |
paulineribeyre
changed the title
| if len(launchTemplate.LaunchTemplates) == 1 { | ||
| // TODO: Make sure user data in the existing launch template matches the user data | ||
| // we want (MIDRC-749) | ||
| // Check if the launch template has block device mappings |
There was a problem hiding this comment.
is there a more generic way to compare the existing launch template to the one in the code? instead of only checking BlockDeviceMappings?
Also, this code wouldn't catch a difference in the BlockDeviceMappings definition, for example if we change the VolumeType, since we only check if there are BlockDeviceMappings at all
Maybe it's fine since this should be deprecated soon, but if we leave it as-is we should write a comment
| LaunchTemplateData: &ec2.RequestLaunchTemplateData{ | ||
| UserData: ltVersion.LaunchTemplateData.UserData, // Preserve existing user data |
There was a problem hiding this comment.
why not update it since the function already generated userData anyway?
| LaunchTemplateName: aws.String(launchTemplateName), | ||
| SourceVersion: aws.String(ltVersionStr), | ||
| VersionDescription: aws.String("Added block device mappings"), | ||
| LaunchTemplateData: &ec2.RequestLaunchTemplateData{ |
There was a problem hiding this comment.
can we reuse instead of duplicating the RequestLaunchTemplateData definition?
3 participants
Link to JIRA ticket if there is one:
New Features
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes