Skip to content

Change fuse-container to non-privileged #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jawadqur wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Change fuse-container to non-privileged #139

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
93f7832
Change fuse-container to non-privileged
jawadqur Feb 2, 2026
f233411
remove bidirectional mount
jawadqur Feb 2, 2026
e670734
remove bidirectional
jawadqur Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions hatchery/pods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
)

var (
trueVal = true

Check failure on line 32 in hatchery/pods.go

View workflow job for this annotation

GitHub Actions / golang-ci 

var `trueVal` is unused (unused)

Check failure on line 32 in hatchery/pods.go

View workflow job for this annotation

GitHub Actions / golang-ci 

var `trueVal` is unused (unused)
falseVal = false
)

Expand Down Expand Up @@ -368,7 +368,7 @@
var sideCarRunAsUser int64
var sideCarRunAsGroup int64
var hostToContainer = k8sv1.MountPropagationHostToContainer
var bidirectional = k8sv1.MountPropagationBidirectional
// var bidirectional = k8sv1.MountPropagationBidirectional
var envVars []k8sv1.EnvVar
// a null image indicates a dockstore app - always mount user volume
mountUserVolume := hatchApp.UserVolumeLocation != ""
Expand Down Expand Up @@ -491,7 +491,7 @@
{
MountPath: "/data",
Name: "shared-data",
MountPropagation: &bidirectional,
// MountPropagation: &hostToContainer,
},
{
MountPath: "/.gen3",
Expand Down Expand Up @@ -547,7 +547,7 @@
Name: "fuse-container",
Image: hatchConfig.Config.Sidecar.Image,
SecurityContext: &k8sv1.SecurityContext{
Privileged: &trueVal,
Privileged: &falseVal,
RunAsUser: &sideCarRunAsUser,
RunAsGroup: &sideCarRunAsGroup,
},
Expand Down
Loading