Add support for hashed usernames in configuration and resource naming#153
Open
jawadqur wants to merge 2 commits into
Open
Add support for hashed usernames in configuration and resource naming#153jawadqur wants to merge 2 commits into
jawadqur wants to merge 2 commits into
Conversation
Integration TestsTest summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
| type HatcheryConfig struct { | ||
| UserNamespace string `json:"user-namespace"` | ||
| DefaultPayModel PayModel `json:"default-pay-model"` | ||
| HashedUsernames bool `json:"hashed-usernames"` |
Contributor
There was a problem hiding this comment.
could you update the config docs and the PR description, making sure to mention that users' previous persistent drives are lost when this setting is changed
Added documentation for 'hashed-usernames' configuration option in Hatchery settings, including its implications on Kubernetes resource naming and PVC management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to JIRA ticket if there is one: https://ctds-planx.atlassian.net/browse/PD-147
Addresses: #144
New Features
This PR adds support for generating Kubernetes-safe resource names from hashed usernames when
Config.Config.HashedUsernameis enabled.When enabled, Hatchery hashes the incoming username and uses the hashed value when generating Kubernetes resources such as pods, services, mappings, and PVCs. This avoids failures caused by long or Kubernetes-incompatible usernames, for example OIDC
subvalues that exceed Kubernetes label or resource-name length limits after escaping.The original username is still used for user identity and request/auth semantics where appropriate, but Kubernetes resource names are generated from the safe hashed username.
Breaking Changes
Bug Fixes
Improvements
Dependency updates
Deployment changes