creating a metadata image with opentelemetry instrumentation.#150
creating a metadata image with opentelemetry instrumentation.#150EliseCastle23 wants to merge 35 commits into
Conversation
|
The style in this PR agrees with This formatting comment was generated automatically by a script in uc-cdis/wool. |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here |
Please find the detailed integration test report here Please find the Github Action logs here |
|
Failed to Prepare CI environment Please find the Github Action logs here |
|
Failed to Prepare CI environment Please find the Github Action logs here |
|
Test summary after running integration tests
Test summary after rerunning failed integration tests
Please find the detailed integration test report here Please find the detailed integration test report after rerunning failed tests here Please find the Github Action logs here |
Avantol13
left a comment
There was a problem hiding this comment.
Thanks for looking into this and for this PoC! We really need better tracing, so I'm looking into how to use this in a new service. A few things I want to improve from this example PoC: more explicit installation, & less boilerplate nesting and tracing logic in the code (this needs to be tucked away in a decorator or function calls in a separate module - it makes the readability of the actual logic a bit fraught if it's not).
I'm not partial to the "auto instrumentation". I would rather be more surgical and do the installs and have the packages reflected in the Python explicitly (so if we need to bump specific packages for security beyond their default auto setup, or the setup randomly break or something, we have more flexibility and don't have broken builds). I appreciate the ease of use and magic of the Dockerfile install, but I don't like not knowing exactly what additional things it's bringing in at build time.
Integrating OpenTelemetry into the Metadata Service.