Skip to content

creating a metadata image with opentelemetry instrumentation.#150

Open
EliseCastle23 wants to merge 35 commits into
masterfrom
feat/GPE-1601
Open

creating a metadata image with opentelemetry instrumentation.#150
EliseCastle23 wants to merge 35 commits into
masterfrom
feat/GPE-1601

Conversation

@EliseCastle23
Copy link
Copy Markdown
Contributor

Integrating OpenTelemetry into the Metadata Service.

@github-actions
Copy link
Copy Markdown

The style in this PR agrees with black. ✔️

This formatting comment was generated automatically by a script in uc-cdis/wool.

@github-actions
Copy link
Copy Markdown

filepath failed SUBTOTAL
tests/test_aggregate_mds.py 1 1
tests/test_discoverypage.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

filepath passed error SUBTOTAL
tests/test_ras_authn.py 0 2 2
tests/test_study_viewer.py 0 1 1
tests/test_pfb_export.py 0 4 4
tests/test_discoverypage.py 1 0 1
tests/test_aggregate_mds.py 1 0 1
TOTAL 2 7 9

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

filepath passed failed SUBTOTAL
tests/test_discoverypage.py 1 0 1
tests/test_aggregate_mds.py 0 1 1
TOTAL 1 1 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2025

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 1, 2025

filepath passed failed SUBTOTAL
tests/test_discoverypage.py 1 0 1
tests/test_aggregate_mds.py 0 1 1
TOTAL 1 1 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 2, 2025

filepath failed SUBTOTAL
tests/test_aggregate_mds.py 1 1
tests/test_discoverypage.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 8, 2025

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 9, 2025

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 9, 2025

filepath passed skipped SUBTOTAL
tests/test_oauth2.py 15 0 15
tests/test_dicom_viewer.py 4 0 4
tests/test_centralized_auth.py 16 0 16
tests/test_graph_submit_and_query.py 13 1 14
tests/test_audit_service.py 3 3 6
tests/test_presigned_url.py 7 0 7
tests/test_pfb_export.py 1 0 1
tests/test_guppy_service.py 8 0 8
tests/test_dbgap.py 4 1 5
tests/test_data_upload.py 8 1 9
tests/test_requestor.py 5 0 5
tests/test_drs_endpoint.py 4 0 4
tests/test_study_viewer.py 3 0 3
tests/test_user_token.py 5 0 5
tests/test_user_data_library.py 2 1 3
tests/test_oidc_client.py 2 0 2
tests/test_login_page.py 2 0 2
tests/test_gen3client.py 1 0 1
tests/test_manifest_service.py 1 0 1
tests/test_discoverypage.py 1 0 1
tests/test_workspace.py 1 0 1
tests/test_aggregate_mds.py 1 0 1
tests/test_google_data_access.py 1 0 1
tests/test_homepage.py 1 0 1
tests/test_client_credentials.py 1 0 1
tests/test_gen3_workflow.py 0 11 11
tests/test_ras_authn.py 0 3 3
tests/test_gen3ff_landing_page.py 0 2 2
tests/test_register_user.py 0 2 2
tests/test_etl.py 0 1 1
TOTAL 110 26 136

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2026

Failed to Prepare CI environment

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2026

Failed to Prepare CI environment

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 2, 2026

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 5, 2026

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

filepath passed SUBTOTAL
tests/test_discoverypage.py 1 1
tests/test_aggregate_mds.py 1 1
TOTAL 2 2

Please find the detailed integration test report here

Please find the Github Action logs here

@github-actions
Copy link
Copy Markdown

Test summary after running integration tests

filepath passed failed SUBTOTAL
tests/test_discoverypage.py 1 0 1
tests/test_aggregate_mds.py 0 1 1
TOTAL 1 1 2

Test summary after rerunning failed integration tests

filepath error SUBTOTAL
tests/test_aggregate_mds.py 1 1
tests/test_discoverypage.py 1 1
tests/test_etl.py 1 1
tests/test_pfb_export.py 1 1
tests/test_ras_authn.py 1 1
tests/test_study_viewer.py 1 1
TOTAL 6 6

Please find the detailed integration test report here

Please find the detailed integration test report after rerunning failed tests here

Please find the Github Action logs here

Copy link
Copy Markdown
Contributor

@Avantol13 Avantol13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this and for this PoC! We really need better tracing, so I'm looking into how to use this in a new service. A few things I want to improve from this example PoC: more explicit installation, & less boilerplate nesting and tracing logic in the code (this needs to be tucked away in a decorator or function calls in a separate module - it makes the readability of the actual logic a bit fraught if it's not).

I'm not partial to the "auto instrumentation". I would rather be more surgical and do the installs and have the packages reflected in the Python explicitly (so if we need to bump specific packages for security beyond their default auto setup, or the setup randomly break or something, we have more flexibility and don't have broken builds). I appreciate the ease of use and magic of the Dockerfile install, but I don't like not knowing exactly what additional things it's bringing in at build time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants