-
Notifications
You must be signed in to change notification settings - Fork 17
Put fw geometry in class #4077
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Put fw geometry in class #4077
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4077 +/- ##
=======================================
Coverage 46.46% 46.47%
=======================================
Files 122 122
Lines 28838 28855 +17
=======================================
+ Hits 13401 13411 +10
- Misses 15437 15444 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c885d83 to
75756d7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the other variables be moved here:
- a_fw_inboard_full_coverage
- a_fw_outboard_full_coverage
- a_fw_total_full_coverage
- a_fw_inboard
- a_fw_outboard
- a_fw_total
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall they go into fwbs_variables.py or shall we make a new fw_variables.py. I prefer the latter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I agree that we can split the FW variables away from the blanket
This pull request refactors the calculation of first wall geometry and area in the codebase. The logic for calculating the first wall's half-height and surface areas has been extracted from
process/build.pyand reimplemented in a more modular and testable way within a newFirstWallclass inprocess/fw.py. Additionally, the codebase is updated to useFirstWallinstead of the oldFwclass, and related variables are initialized and managed more cleanly. Associated tests and fixtures are updated to use the new class.Key changes include:
Refactoring and Code Organization
process/build.pyto new static methods in theFirstWallclass inprocess/fw.py, improving modularity and maintainability.Fwclass is replaced with the newFirstWallclass throughout the codebase, including inprocess/main.py, integration tests, and unit tests.Variable Initialization and Data Structure Updates
dz_fw_half) is added tofwbs_variablesand properly initialized inprocess/data_structure/fwbs_variables.py.Imports and Cleanup
process/build.py.These changes make the codebase cleaner, easier to test, and more maintainable by encapsulating first wall calculations in a dedicated class and updating all relevant usages.## Description
Checklist
I confirm that I have completed the following checks: