Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4081 +/- ##
=======================================
Coverage 46.46% 46.46%
=======================================
Files 122 122
Lines 28838 28838
=======================================
Hits 13401 13401
Misses 15437 15437 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
chris-ashe
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
dr_tf_inboard = 0.9tospherical_tokamak_eval.IN.DAT, the value is taken from thest_regression.IN.DAToptimised solution.This was causing the winding pack to become excessively large, meaning the cable plotting algorithm was iterating over trillions of elements:
dr_tf_inboardwas0(its default) which causeddr_tf_wp_with_insulationto become negativePROCESS/process/build.py
Lines 1783 to 1790 in 40782b5
j_tf_wfto become1PROCESS/process/superconducting_tf_coil.py
Lines 2722 to 2729 in 40782b5
st_regression.IN.DAT) anddx_tf_turn_generalis consequently larger (~250m rather than a couple of cm/mm).PROCESS/process/superconducting_tf_coil.py
Lines 2784 to 2787 in 40782b5
n_rows = 340377,n_cols = 294775) which causes the for loop to iterate ~st_regression.IN.DAT