Run as root by default to fix docker socket access#58
Merged
umputun merged 2 commits intoumputun:masterfrom Mar 1, 2026
Merged
Run as root by default to fix docker socket access#58umputun merged 2 commits intoumputun:masterfrom
umputun merged 2 commits intoumputun:masterfrom
Conversation
Previously, the container ran as non-root user app (UID 1001) which failed on most systems because the docker socket GID didn't match the container's docker group GID (999). The v1.3.0 image ran as root and worked out of the box; v1.4.0 switched to non-root via the updated baseimage and broke existing setups. Set APP_UID=0 in the Dockerfile to restore root execution as default. Add documented APP_UID/DOCKER_GID options in docker-compose.yml and a "Running as Non-Root" section in README for users who prefer to drop privileges. Resolves #57
Pull Request Test Coverage Report for Build 22531343651Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
umputun
reviewed
Feb 28, 2026
Owner
umputun
left a comment
There was a problem hiding this comment.
looks good overall, thx. one thing - TIME_ZONE=America/Chicago got uncommented in docker-compose.yml, so now it's active by default. seems unrelated to the root/non-root fix, probably should stay commented out
Contributor
Author
|
Done, please take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
APP_UID=0in the Dockerfile to run as root by default, restoring v1.3.0 behaviour. The updated baseimage switched to non-root execution (UID 1001) which broke docker socket access on most systems where the socket GID doesn't match the container's default docker group GID (999).APP_UIDandDOCKER_GIDoptions todocker-compose.ymlwith an explanation of how to run as non-root.chown -R app:app /srvfrom Dockerfile (redundant when running as root).version: '2'from docker-compose.yml, uncommentedTIME_ZONE.as→AScasing in Dockerfile multi-stage build.Resolves #57