autocomplete tags#657
Conversation
|
Here's the code health analysis summary for commits Analysis Summary
|
pozylon
force-pushed
the
autocomplete-product-tags
branch
from
696994c to
3656afa
Compare
There was a problem hiding this comment.
Add this to your solution please:
- Allow to set the tags via adminUiConfig property in startPlatform. Env variables should not be the only option to configure this.
- If you frame it "product tags" also make sure to name it more explicit in the ShopInfo: productTags.
- Also support configuring the assortment tags as tagging assortments is similar important to products because we allow filtering by it in Query.assortments like in Query.products
Ah, and while you're doing this, I spotted "externalLinks" which is built only from env. Can you please do the same and allow it beeing set also via adminUiConfig and not only via env? Similarily singleSignOnURL and customProperties should both also be configurable through env. My goal is actually that all the adminUiConfig options can be set either by code or by env. Env should take precedence.
Mikearaya
force-pushed
the
autocomplete-product-tags
branch
from
3656afa to
9efbaef
Compare
pozylon
left a comment
pozylon
left a comment
There was a problem hiding this comment.
Almost there, only some fine grained suggestions left
| const products = await configureProductsModule({ | ||
| db, | ||
| migrationRepository, | ||
| options: options.products, |
There was a problem hiding this comment.
currently nothing is passed but i noticed that it was the only that module options not passed down to it. (consistency)
2 participants
Closes #441
defaults can be customized by providing comma separated string using UNCHAINED_DEFAULT_PRODUCT_TAGS env