Towards making it work with latest Unikraft updates#13
Open
skuenzer wants to merge 3 commits intounikraft:stagingfrom
Open
Towards making it work with latest Unikraft updates#13skuenzer wants to merge 3 commits intounikraft:stagingfrom
skuenzer wants to merge 3 commits intounikraft:stagingfrom
Conversation
This solves incompatibilities with the core library `uklibid`. Signed-off-by: Simon Kuenzer <simon@unikraft.io>
Signed-off-by: Simon Kuenzer <simon@unikraft.io>
This commit adopts the glue code to work with the Unikraft updates introduced with [PR #1148](unikraft/unikraft#1148). Signed-off-by: Simon Kuenzer <simon@unikraft.io>
mariapana
approved these changes
Mar 30, 2024
mariapana
left a comment
mariapana
left a comment
There was a problem hiding this comment.
Looks good.
Reviewed-by: Maria Pana maria.pana4@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings pthread-embedded closer to work again with Unikraft version on
staging(at the time of this writing commit46754d7). Please note that needed adoptions due tolib/ukschedupdates are not included in this PR yet. These need to be solved additionally. However, this PR solves incompatibilites introduced withlib/uklibidand inittab updates.