Open
Conversation
Return wall clock on calling `ftime`, since the function is used in `pte_relmillisecs` to find the time offset as milliseconds from the current system time. `pte_relmillisecs` returns timeout as milliseconds from current system time, got by calling `ftime`. `sem_timedwait` calculates the time offset using `pte_relmillisecs` and then waits in a loop. Using monotonic time results in a wrong offset when using `sem_timedwait` that makes the `abstime` argument be interpreted as a relative offset to the monotonic clock start, not as an absolute value since epoch. Signed-off-by: Stefan Jumarea <stefanjumarea02@gmail.com>
adinasm
approved these changes
May 25, 2022
adinasm
left a comment
adinasm
left a comment
There was a problem hiding this comment.
Looks good, seems like the bug is gone now.
Reviewed-by: Adina Smeu adina.smeu@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem was discussed here.
Return wall clock on calling
ftime, since thefunction is used in
pte_relmillisecsto findthe time offset as milliseconds from the current
system time.
pte_relmillisecsreturns timeout as millisecondsfrom current system time, got by calling
ftimehere.sem_timedwaitcalculates the time offset usingpte_relmillisecshere and then waits in a loop.Using monotonic time results in a wrong offset
when using
sem_timedwaitthat makes theabstimeargument be interpreted as a relative offset to
the monotonic clock start, not as an absolute value
since epoch.
Signed-off-by: Stefan Jumarea stefanjumarea02@gmail.com