Fix incompatible pointer type warning by typecast#8
Open
852866031 wants to merge 1 commit intounikraft:stagingfrom
Open
Fix incompatible pointer type warning by typecast#8852866031 wants to merge 1 commit intounikraft:stagingfrom
852866031 wants to merge 1 commit intounikraft:stagingfrom
Conversation
razvand
approved these changes
May 15, 2022
razvand
left a comment
razvand
left a comment
There was a problem hiding this comment.
Thanks, @852866031 , it looks good to me.
ouss-ch
approved these changes
Jun 26, 2022
ouss-ch
left a comment
ouss-ch
left a comment
There was a problem hiding this comment.
Looks good. Good job!
Reviewed by Oussama "ouss-chayeb@gmail.com"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a part of work for Unikraft Lyon Hackathon.
When building app-nginx, the warning below occurred
/home/ubuntu/workdir/libs/lib-pthread-embedded/attributes.c: In function ‘pthread_setname_np’: /home/ubuntu/workdir/libs/lib-pthread-embedded/attributes.c:122:13: warning: assignment to ‘struct uk_thread *’ from incompatible pointer type ‘pte_osThreadHandle’ {aka ‘struct pte_thread_data *’} [-Wincompatible-pointer-types]
To fix it we add typecast expressions on the corresponding statements