Skip to content

Dark mode versioning #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tr0njavolta merged 3 commits into from
May 7, 2026
Merged

Dark mode versioning #1171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9df4c9f
Removes duplicate latest version
tr0njavolta May 7, 2026
a50dc35
corrects dark mode on version dropdown
tr0njavolta May 7, 2026
79465ed
Merge branch 'main' into dark-mode-versioning
tr0njavolta May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions src/css/custom.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,28 @@ nav[aria-label="Main"] .text-neutral-0, nav[aria-label="Main"] .text-neutral-0:h
color: rgb(255 255 255 / var(--tw-text-opacity));
}

/* Spaces sidebar version selector — @upbound/elements Select uses Tailwind */
/* utility classes (bg-background, border-input, etc.) that are compiled with */
/* hardcoded light values and no `.dark:` variants, so dark mode needs explicit overrides. */
html[data-theme="dark"] .spaces-version-trigger,
html[data-theme="dark"] .spaces-version-content {
background-color: var(--ifm-background-color);
border-color: var(--upbound-border-color);
color: var(--ifm-font-color-base);
}
html[data-theme="dark"] .spaces-version-trigger svg,
html[data-theme="dark"] .spaces-version-content svg {
color: var(--ifm-font-color-base);
}
html[data-theme="dark"] .spaces-version-item {
color: var(--ifm-font-color-base);
}
html[data-theme="dark"] .spaces-version-item:focus,
html[data-theme="dark"] .spaces-version-item[data-highlighted] {
background-color: var(--upbound-light-bg);
color: var(--ifm-font-color-base);
}

/* Navbar dropdown popover - theme agnostic */
/* Target navigation menu dropdowns rendered via Radix portal */
/* Dropdown has white background in both modes, so always use dark text */
Expand Down
6 changes: 3 additions & 3 deletions src/theme/DocSidebar/Desktop/Content/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ export default function DocSidebarDesktopContentWrapper(props) {
value={getVersionFromPath(location.pathname)}
onValueChange={handleVersionChange}
>
<SelectTrigger className={styles.trigger}>
<SelectTrigger className={`${styles.trigger} spaces-version-trigger`}>
<SelectValue />
</SelectTrigger>
<SelectContent>
<SelectContent className="spaces-version-content">
{versions.map((v) => (
<SelectItem key={v.value} value={v.value}>
<SelectItem key={v.value} value={v.value} className="spaces-version-item">
{v.label}
</SelectItem>
))}
Expand Down
2 changes: 1 addition & 1 deletion src/theme/Root.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function Root({ children }) {

useEffect(() => {
if (!isBrowser) return;

// Add Scarf pixel
const scarfImg = document.createElement('img');
scarfImg.referrerPolicy = 'no-referrer-when-downgrade';
Expand Down
Loading