fix(ci): 修复 PR #24 review 反馈 — ruff/mypy CI 加固 + pyproject.toml + __all__ 修正#29
Merged
Conversation
3 tasks
…ll__ 修正 Critical 修复: - 移除 ruff/mypy 的 `|| true`,CI 检查失败将正确阻断流水线 - 移除 ruff 的 `--fix` 标志,CI 中不应原地修改文件 Major 修复: - 添加 pyproject.toml (ruff + mypy 配置),本地开发者可复现 CI 检查 - 移除 types-requests 依赖(项目仅使用 stdlib urllib.request) - __all__ 中移除 15 个 _ 前缀私有名称,添加 __version__ Minor 修复: - ruff 规则扩展: E,F → E,F,W (增加 warnings) - CI 依赖仅保留: pytest, pytest-mock, ruff, mypy Refs: #13 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
9bfbc10 to
db4c328
Compare
Owner
Author
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复 PR #24 Review 反馈
基于 PR #24 的 Code Review 反馈,修正所有 Critical 和 Major 问题。
Critical 修复
ruff和mypy都使用|| true,CI 永远不会失败|| true,检查失败将正确阻断 CI--fix在 CI 中无意义--fix,CI 仅做检查不修改文件Major 修复
pyproject.tomlpyproject.toml(ruff + mypy 配置),本地可复现 CItypes-requests依赖urllib.request)__all__列出 15 个_前缀私有名称__version__Minor 修复
__version__未包含在__all__--select=E,F过于狭窄E,F,W变更文件
.github/workflows/test.yml|| true、--fix;扩展 ruff 规则;移除 types-requestsagent_go/__init__.py__all__仅含公共符号 +__version__pyproject.toml测试
Closes #13