fix: resolve build errors and manifest issues#30
Open
AryaKoureshi wants to merge 2 commits into
Open
Conversation
- Replace rm with rimraf for Windows compatibility in build script - Remove @crxjs/vite-plugin to fix rollup parse errors and audit issues - Fix webExtension plugin TypeScript signature in Vite config - Fix manifest icon paths for production build
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Replaces the @crxjs/vite-plugin with @samrum/vite-plugin-web-extension for building the browser extension, updates the manifest configuration accordingly, and adjusts related tooling.
Changes:
- Swap
@crxjs/vite-pluginfor@samrum/vite-plugin-web-extensionin Vite config and manifest definition. - Update icon paths in manifest from
public/logo.pngtologo.png. - Replace
rm -rfclean script withrimrafand add it as a devDependency.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| vite.config.ts | Replaces crx plugin with webExtension plugin and reorders plugins. |
| package.json | Removes @crxjs/vite-plugin, adds @samrum/vite-plugin-web-extension and rimraf; updates clean script. |
| manifest.config.ts | Drops defineManifest helper, exports plain object, updates icon paths. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+18
to
+20
| webExtension({ manifest } as any) as any, | ||
| react(), | ||
|
|
| import pkg from "./package.json"; | ||
|
|
||
| export default defineManifest({ | ||
| export default { |
| default_locale: "en", | ||
| icons: { | ||
| 48: "public/logo.png", | ||
| 48: "logo.png", |
Author
|
Updated with follow-up fixes in 2c58c09. Changes:
Verified locally:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Windows build & npm audit/rollup errors
rm -rfwithrimraffor Windows cross-compatibility.@crxjs/vite-plugincausing Rollup config errors and security audit warnings, returningmanifest.config.tsto a plain export.@samrum/vite-plugin-web-extensionTypeScript signature conflict in Vite config.public/directory icon pathing pointing correctly todist/root in production builds.