Fix variable size on step_pulse_time for STM32 targets #66
Open
duembeg wants to merge 2 commits intousbcnc:edgefrom
Open
Fix variable size on step_pulse_time for STM32 targets #66duembeg wants to merge 2 commits intousbcnc:edgefrom
duembeg wants to merge 2 commits intousbcnc:edgefrom
Conversation
* Fixed issue with size of step_pulse_time, it is a uint8 but for STM32 and clk source of 72MHz these would be 720 for 10us pulse; uint8 can only hold 255 max. Changed type to uint16 on stm32 targets.
Fix bug with size for step_pulse_time for STM32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
and clk source of 72MHz these would be 720 for 10us pulse; uint8 can
only hold 255 max. Changed type to uint16 on stm32 targets.
Currently is being truncated 0x2D0 to 0xD0 (208).