Improve mkcert fallback handling in Makefile#4076
Open
tobybellwood wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <copilot@github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the robustness of the local k3d charts checkout flow by making certificate copying resilient when mkcert isn’t installed, falling back to the repo’s locally generated CA files.
Changes:
- Add a
mkcertexistence check before callingmkcert -CAROOTduringk3d/checkout-charts. - Ensure the Makefile falls back to
local-dev/certificateswhenmkcertis unavailable (or produces no CAROOT).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhance the handling of mkcert in the Makefile to ensure a fallback mechanism is in place when mkcert is not available. This change addresses potential issues with certificate generation by checking for mkcert's existence before attempting to use it.