build: reinstall uniffi-bindgen-go when the installed version is stale #409
Open
kcalvinalvin wants to merge 1 commit into
Open
build: reinstall uniffi-bindgen-go when the installed version is stale #409kcalvinalvin wants to merge 1 commit into
kcalvinalvin wants to merge 1 commit into
Conversation
The previous check only verified that the binary existed on PATH, so a user with an older uniffi-bindgen-go from a prior project setup would silently use it and generate bindings that don't match the current bdkgo.h/bdkgo.go expected by the codebase. Pin the version as a Makefile variable, compare against --version, and use --force on cargo install so a stale binary is actually replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous check only verified that the binary existed on PATH, so a
user with an older uniffi-bindgen-go from a prior project setup would
silently use it and generate bindings that don't match the current
bdkgo.h/bdkgo.go expected by the codebase. Pin the version as a Makefile
variable, compare against --version, and use --force on cargo install so
a stale binary is actually replaced.