Conversation
Add 7 new auth tables (auth_users, auth_roles, auth_user_roles, auth_identities, auth_policies, auth_user_agents, auth_sessions) and scope column to settings_agents. Generate Atlas migration.
Add query files for auth_users, auth_roles, auth_user_roles, auth_identities, auth_policies, auth_user_agents, auth_sessions. Regenerate sqlc to include new auth types and updated settings_agents.
…e, and DB implementation - types.go: AuthUser, Role, Policy, AccessRequest, Subject, Resource, Action, Identity, Session - password.go: bcrypt hash/verify with cost=12 - store.go: AuthStore interface (separate from config.Store) - authdb/store.go: SQLite implementation using sqlc queries
- password_test.go: hash, verify, wrong password, empty hash - authdb/store_test.go: CRUD for users, roles, identities, policies, user-agent assignments, sessions; cascade delete; interface check
- Change UpdateSessionExpiry to accept time.Time instead of string - Wrap all error returns with fmt.Errorf context - Log parseTime failures instead of silently discarding
Implements the ABAC policy evaluation engine for Phase 2: - PolicyEngine loads enabled policies sorted by priority - Can/Must methods evaluate access requests - Deny-overrides algorithm: any deny wins, at least one allow needed - Condition evaluator supports eq, neq, in, not_in, contains operators - Attribute references (subject.id, resource.owner_id, etc.)
Seeds 2 system roles (admin, user) and 8 built-in ABAC policies on bootstrap. Uses idempotent pattern — existing entries are skipped.
Calls auth.SeedRolesAndPolicies after DB migrations and config seed, ensuring built-in roles and policies exist on every startup.
Tests cover: - Condition evaluation (eq, neq, in, not_in, contains, attr refs, AND logic) - Policy matching (roles, actions, resources, wildcards, invalid JSON) - Deny-overrides (deny wins, default deny, allow when matched) - Built-in policy scenarios (admin full access, user own data, etc.) - Seed idempotency (run twice without error) - Engine creation from seeded DB
- session.go: crypto/rand session IDs (32 bytes hex), cookie helpers (HttpOnly, SameSite=Lax, Secure flag, 7-day MaxAge) - ratelimit.go: in-memory rate limiter with per-IP (10 req/min) and per-username (5 failures -> 30s cooldown) throttling via sync.Map - Tests for both packages with -race
- login.templ: login form with register toggle, daisyUI styled - login.js: Alpine.js component for login/register API calls - loginlayout.templ: standalone layout without navbar for login page
- auth.go: register, login, logout, me API handlers - middleware.go: session-based auth middleware + admin-only guard - server.go: CORS hardening (configurable origin, credentials), auth middleware on all routes, admin-only route guards, role-based root redirect (unauth->login, user->agents, admin->providers) - navbar.templ: role-based nav items, username + logout button - layout.templ: pass username/isAdmin to navbar - render.go: extract auth info from context for page rendering - Updated callers in cmd/anna (gateway.go, onboard.go) to pass AuthStore and PolicyEngine to admin.New()
- auth_test.go: register, login, logout, /me, password validation, duplicate username, wrong password, first-user admin role, expired session denial - server_test.go: updated for auth-aware server (session cookies, admin/non-admin access control, unauthenticated redirects)
- Separate CheckIP from RecordIPAttempt (no counter on check) - Add rate limiting to register endpoint - Add username (max 64) and password (max 72) length limits - Fix first-user race: check count before creating user - Make agent CRUD (POST/PUT/DELETE) admin-only - Cache CORS origin at startup instead of per-request DB query - Set Secure=true on ClearSessionCookie for HTTPS compat
…link code store - Create internal/auth/linkcode.go: in-memory LinkCodeStore with sync.Map, 5-min TTL - Create profile templ page with password change form, linked identities list, and link code generation - Create profile.js Alpine component with full CRUD for identities and password - Create profile API handlers: list/unlink identities, change password, generate link code - Add /profile page route, profile API routes, and LinkCodes accessor on Server - Make username in navbar a clickable link to /profile
- Create internal/channel/linkcode.go: shared TryLinkCode function - Add WithAuth option to telegram, qq, feishu bots - Intercept 6-char alphanumeric codes in text handlers before command processing - Create auth_identity on valid code, reply with success/error message - Platform mismatch detection (code for telegram sent to qq, etc.)
- Add ResolvedIdentity type with AuthUserID and Roles fields - Add ResolveUserWithAuth: auth_identities lookup -> auto-migrate from settings_users - Add ResolveWithAuth for auth-aware full resolution path - Auto-migration: creates auth_user + auth_identity for unlinked settings_users - Channel bots use ResolveWithAuth when authStore is configured - Backward compatible: falls back to legacy Resolve when auth not configured
…entity resolution - LinkCodeStore tests: generate, consume, single-use, case-insensitive, uniqueness, IsLinkCode - Profile API tests: list identities, change password, generate link code, unlink identity, ownership check - Identity resolution tests: auto-migration, linked identity lookup, idempotency - TryLinkCode tests: success, wrong platform, invalid code, non-code text - All tests pass with -race
Add AgentScopeSystem and AgentScopeRestricted constants. Map scope column in agentFromDB, CreateAgent, UpdateAgent, and SeedDefaults. Update sqlc queries to include scope in INSERT and UPDATE.
- Add GET/POST/DELETE /api/agents/{id}/users endpoints (admin-only)
- Add scope dropdown and user assignment modal to agents page
- Filter agent list/get by policy engine for non-admin users
- Non-admin users see only system-scoped + assigned agents
- Tests for scope CRUD, user assignment, and access filtering
- Add ResolveAgentWithAuth with policy engine access checks - Return ErrAgentAccessDenied when user cannot access an agent - Filter fallback agent list by accessible agents - Add engine field to Telegram/QQ/Feishu bots via WithAuth option - Update ResolveWithAuth to pass engine through to agent resolution - Tests for system/restricted/admin/fallback/group-chat scenarios
…eway Move auth store and policy engine creation before bot initialization so all channel bots get WithAuth with auth store, engine, and link codes. This enables agent access enforcement on all channel messages.
- Add SetupUserWorkspace() for per-user dirs under workspaces/{agentID}/users/{userID}/
- Add UserSkillsDir/UserDataDir helpers
- Modify SkillsTool to accept userID; per-user skills path when userID > 0
- Update install/list/load/remove to use per-user skillsDir()
- Update LoadSkills priority chain: project > user > agent > common > builtin
- Add UserSkillsDir field to DBPromptParams for prompt building
- Comprehensive tests for workspace isolation and per-user skills
- Add UserID to RunnerParams, pass through pool -> factory - Create per-user workspace and tools in factory when UserID > 0 - Add UserDataDir to GoRunnerConfig for sandbox-aware tool registry - Add auth.ValidatePath() with symlink resolution for path sandbox - Add sandboxTool wrapper for read/write/edit tools - Bash tool uses user data dir as CWD when available - Add AgentID to config.Snapshot for per-user workspace setup - Tests for sandbox validation, symlink escape, prefix confusion
…ent assignments (Phase 7)
- Add auth user management API endpoints under /api/auth/users/:
- GET /api/auth/users — list all auth users with roles and identities
- GET /api/auth/users/{id} — get user detail
- PUT /api/auth/users/{id}/roles — assign/remove roles (cannot remove own admin)
- GET/PUT /api/auth/users/{id}/agents — list/set agent assignments
- PUT /api/auth/users/{id}/active — activate/deactivate (force logout on deactivate)
- Replace users page with tabbed layout: Auth Users (primary) + User Memory (legacy)
- Auth Users tab shows: username, roles badges, active status, linked identities
- User detail panel: roles management, identity list, agent assignments, activate/deactivate
- Preserve legacy /api/users endpoints for backward-compatible memory management
- All new endpoints are admin-only
- Tests: 13 new tests covering all endpoints, access control, self-protection guards
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f4fbdf01a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
133
to
134
| s.mux.HandleFunc("GET /api/sessions/{sessionID}/messages", s.getSessionMessages) | ||
| s.mux.HandleFunc("GET /api/sessions/{sessionID}/system-prompt", s.getSessionSystemPrompt) |
There was a problem hiding this comment.
After this commit, regular authenticated users can hit these routes because they are no longer wrapped in adminAPI(...). The handlers in internal/admin/sessions.go still return global data (ListInfo(..., true), raw messages, and system prompts) without checking UserFromContext, so any non-admin account can browse every user's conversation history and prompts via /api/sessions/*.
Useful? React with 👍 / 👎.
cmd/anna/gateway.go
Outdated
Comment on lines
+94
to
+96
| // Link codes are shared between admin panel and channel bots. For now, | ||
| // create a standalone store since we might not have an admin panel. | ||
| linkCodes := auth.NewLinkCodeStore() |
There was a problem hiding this comment.
When gateway runs with --admin-port, the profile page generates codes from the LinkCodeStore allocated inside admin.New(...), but the channel bots are wired to the separate store created here. In that deployment every code produced by the admin UI will be reported as invalid/expired by Telegram/QQ/Feishu, so identity linking never succeeds.
Useful? React with 👍 / 👎.
Comment on lines
+51
to
+54
| async loadAllUsers() { | ||
| try { | ||
| const users = await api('GET', '/api/users') | ||
| this.allUsers = users || [] |
There was a problem hiding this comment.
This modal loads /api/users, which is the legacy settings_users list used for memories, but POST /api/agents/{id}/users validates user_id against auth_users in assignAgentUser. As a result, admin-created accounts that have never sent a channel message never appear in the picker, and once the numeric IDs in the two tables diverge the UI can submit the wrong user for assignment.
Useful? React with 👍 / 👎.
📊 Coverage ReportTotal coverage: 44.9% Per-package breakdown |
…kage - Remove `anna onboard` and `anna gateway` subcommands - `anna` (bare) is now the default server action (admin panel + channels) - Add `--open` flag to launch browser, `--admin-port` with PORT env support - Default admin port: 25678 - Move `internal/auth/authdb/` → `internal/db/authstore.go` - Rename mise tasks: `atlas:*` → `db:*`, remove redundant tasks - Update all docs (en/zh/ja), builtin skill, README, CLAUDE.md
- Scheduler: users see/manage only their own jobs, admins see all and can create system jobs (user_id=0) that broadcast to everyone - Sessions: non-admin users only see their own sessions - Notifications: user-owned scheduler jobs notify only the owner via their linked channel identities; system jobs broadcast to all - Add system:user-own-scheduler seed policy - Open scheduler page/APIs to all authenticated users with handler-level RBAC instead of admin-only middleware - Add NotifyUser to Dispatcher with graceful fallback to broadcast
- Add DELETE /api/auth/users/{id}/identities/{identityId} endpoint
- Add unlink button in user detail panel's identities section
- Allows admin to detach channel identities from users so they can be
re-linked to different accounts
The admin panel and channel bots each created their own LinkCodeStore, so link codes generated in the admin profile page were never found by channel handlers. Pass the shared store into admin.New() instead. Also fix click.away on user detail panel closing when confirm dialog is open, causing "selectedUser is null" errors on identity unlink.
…nking - Remove auto-migration in ResolveUserWithAuth — unlinked channel users now get settings_users only (no auth user created automatically) - Change link code format from bare code to "/link <code>" command (bare codes still accepted for backward compat) - Improve error messages for expired/wrong-platform/already-linked cases - Update profile page: show "/link <code>" with copy button - Remove dead randomPassword helper
ResolvedChat.UserID() now prefers AuthUserID (auth_users.id) over User.ID (settings_users.id). This ensures sessions and per-user memory are scoped to the correct auth user after identity re-linking.
The user_id column now stores auth_users.id for RBAC users but settings_users.id for legacy CLI users. Drop the FK constraint to support both ID spaces.
The session detail page was looking up user name via config.Store.GetUser (settings_users table) but the user_id in sessions is now auth_users.id. Switch to authStore.GetUser to show the correct username.
Drop settings_users table entirely. auth_users now has default_agent_id and is the single user table. Key changes: - auth.AuthUser gains DefaultAgentID field - auth.AuthStore gains UpdateUserDefaultAgent method - config.Store loses User type and all user methods - channel.ResolveUser now takes authStore only (no config.Store) - channel.ResolvedIdentity uses auth.AuthUser directly - channel.ResolvedChat carries single User field (no dual ID) - channel.ResolveAgent unified (no separate WithAuth variant) - Channel bots use single Resolve path - Admin /api/users legacy endpoints removed - All tests updated
Owner
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 68e47ec05e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+16
to
+17
| -- Copy rows from old table "auth_users" to new temporary table "new_auth_users" | ||
| INSERT INTO `new_auth_users` (`id`, `username`, `password_hash`, `is_active`, `created_at`, `updated_at`) SELECT `id`, `username`, IFNULL(`password_hash`, '') AS `password_hash`, `is_active`, `created_at`, `updated_at` FROM `auth_users`; |
There was a problem hiding this comment.
On upgrades from the pre-auth schema, this migration repopulates new_auth_users only from the transient auth_users table and never carries over the existing settings_users rows that owned default_agent_id and ctx_agent_memory. Because the earlier fix_memory_user_fk migration intentionally leaves memories keyed by raw user_id, newly registered auth users can collide with those legacy IDs and inherit another user's memory/default-agent state, while the original channel users lose access entirely. This needs to migrate settings_users into auth_users/auth_identities before the drop.
Useful? React with 👍 / 👎.
internal/channel/identity.go
Outdated
Comment on lines
+36
to
+39
| identity, err := authStore.GetIdentityByPlatform(ctx, platform, externalID) | ||
| if err != nil { | ||
| return config.User{}, fmt.Errorf("resolve user: %w", err) | ||
| log.Debug("no linked identity found, user must link via link code") | ||
| return ResolvedIdentity{}, nil |
There was a problem hiding this comment.
This treats every GetIdentityByPlatform failure as 'unlinked user'. If SQLite returns a real error here (for example a locked database or schema problem), ResolveAgent later sees identity.User.ID == 0 and skips RBAC entirely, routing the message as an unrestricted guest. The GetUser fallback a few lines below has the same fail-open behavior, so only not-found errors should be downgraded to an anonymous identity.
Useful? React with 👍 / 👎.
| async loadLegacyUsers() { | ||
| if (this.legacyUsers.length > 0) return // already loaded | ||
| try { | ||
| const list = await api('GET', '/api/users') || [] |
There was a problem hiding this comment.
The retained legacy-memory UI still calls GET /api/users, but internal/admin/server.go in this commit no longer registers that route and only keeps /api/users/{id}/default-agent plus the memory endpoints. As soon as an admin opens the Memory tab, the initial load 404s, so the old per-user memory/default-agent editor is no longer usable on upgraded instances.
Useful? React with 👍 / 👎.
- Fail closed on DB errors in ResolveUser — only treat sql.ErrNoRows as "unlinked user", propagate real DB errors instead of silently falling back to anonymous identity - Fix agent user assignment picker: load from /api/auth/users instead of removed /api/users (settings_users) - Fix memory tab: load from /api/auth/users, map username field
Drop auth_roles and auth_user_roles tables. Each user now has a single role column (TEXT, default 'user'). No per-request ListUserRoles query. - AuthUser gains Role field, IsAdmin() helper - AuthStore: remove role CRUD (CreateRole, ListRoles, etc.) - AuthStore: add UpdateUserRole(userID, role) - Middleware: read role from user row directly (no join query) - Seed: SeedRolesAndPolicies renamed to SeedPolicies (no role table) - Admin UI: single role badge, promote/demote buttons - Policy engine unchanged (subjects.roles still works as []string) - -621 lines net deletion
Linked auth users in private chats now share a single session across all channels (Telegram, QQ, Feishu). Session key uses auth user ID instead of platform-specific external ID. Group chats remain platform-specific.
…contrast - Merge "Linked Identities" and "Link New Identity" into one section - Hide link buttons for platforms already linked - Replace alert-info with neutral alert for better link code readability - Add isLinked() helper to profile JS
Users can now view, edit, and delete their own per-agent memories from the profile page. Previously only admins could manage user memories. New profile API endpoints scoped to the authenticated user.
Memory is per-agent, so it belongs on the agent page. Each agent row now has a "My Memory" toggle that loads/saves the current user's memory for that agent. Profile page no longer shows memory section.
…eation - Add creator_id column to settings_agents (migration) - Auto-generate agent ID from name (slugify with dedup) - Remove ID and workspace fields from create form - Non-admin users: scope forced to restricted, auto-assigned - Admin-only scope selector, creator or admin can edit/delete - Open POST/PUT/DELETE /api/agents to all auth users (with access checks) - Update all agent tests for auto-generated IDs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Full RBAC + ABAC permission system for anna with unified user management and per-user data isolation.
Key changes
auth_usersis the only user table (settings_userseliminated). Channel identities linked viaauth_identities./link <code>command flow — generate code in admin profile, send to bot.Dispatcher.NotifyUserresolves channel identities to target specific users.DB changes
auth_usersnow includesdefault_agent_id(absorbed from droppedsettings_users)settings_userstable droppedauth_users,auth_roles,auth_user_roles,auth_identities,auth_policies,auth_user_agents,auth_sessionssettings_agents.scopecolumn addedctx_agent_memory.user_idFK dropped (supports both legacy and auth user IDs)add-auth-tables,fix_memory_user_fk,consolidate_usersArchitecture
internal/auth/— Types, policy engine, password, sessions, rate limiter, sandbox, link codes, seedinternal/db/authstore.go— SQLite AuthStore implementationinternal/channel/identity.go— SingleResolveUserpath via auth_identitiesinternal/channel/resolved.go—ResolvedChatwith singleauth.AuthUser(no dual ID)internal/channel/notifier.go—NotifyUserfor per-user notification routingTest plan
-raceflag/link <code>flow