feat(ui): add sidebar appearance settings#13
Closed
noodanee wants to merge 1 commit intovaayne:mainfrom
Closed
Conversation
Add user-configurable sidebar appearance with font family, font size, and spacing controls. Settings persist via UserDefaults and take effect immediately across all sidebar views. - New SidebarAppearance model with Environment-based propagation - SidebarAppearanceStore (@observable) with UserDefaults persistence - "Appearance" category in Settings UI with font picker, size slider (10-22pt), spacing slider (0.8x-1.8x), and live preview - All sidebar views (WorktreeSidebar, WorktreeRow, WindowRow, ProjectRail) read appearance from @Environment - Default font size bumped from 13pt to 14pt for better readability
Owner
|
@noodanee Can you resolve all conflicts? |
Author
|
Closing — will resubmit based on latest main with i18n and TaskSidebarView coverage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New:
SidebarAppearancemodel (MoriCore)fontFamily,fontSize,spacingpropertiesFontStyleenum with relative size calculations from base fontSizeEnvironmentKeyfor propagation through view hierarchySidebarAppearanceStorewith@Observable+UserDefaultspersistenceSettings UI (
GhosttySettingsView).appearancecategory (first in sidebar list)Sidebar views updated
WorktreeSidebarView,WorktreeRowView,WindowRowView,ProjectRailViewSidebarAppearancefrom@Environment(\.sidebarAppearance)appearance.font(.style), scaled spacing viaappearance.scaled()Wiring (
AppDelegate+HostingControllers)SidebarAppearanceStorecreated in AppDelegate, passed to sidebar and settingsSidebarContentViewinjects appearance into environmentTest plan