Conversation
malleoz
reviewed
Nov 3, 2024
|
|
||
| void CTGPMetadata::read(const CTGPGhostFooter *data) { | ||
| if (!data) { | ||
| isCTGP = false; |
Collaborator
There was a problem hiding this comment.
Since this is initialized to false, can we assume that this line can be removed as redundant?
Owner
Author
There was a problem hiding this comment.
The read function should guarantee state, regardless of previous condition.
| u8 trackSHA1[20]; | ||
| u64 ghostDBPlayerID; | ||
| f32 trueFinishTime; | ||
| u8 _20[0x27 - 0x20]; |
Collaborator
There was a problem hiding this comment.
Can you add @unused doxygen comment I guess?
Owner
Author
There was a problem hiding this comment.
Can you provide an example of what that looks like?
Collaborator
There was a problem hiding this comment.
f32 m_angVel0YFactor; ///< Scalar for damping angular velocity.
bool m_forceUpright; ///< Specifies if we should return the vehicle to upwards orientation.
bool m_noGravity; ///< @unused
vabold
force-pushed
the
ghost
branch
2 times, most recently
from
954dddc to
f8d4e35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.