feat: group php namespace to ts namespaces#15
Open
rick-bongers wants to merge 1 commit intovagebnd:mainfrom
Open
feat: group php namespace to ts namespaces#15rick-bongers wants to merge 1 commit intovagebnd:mainfrom
rick-bongers wants to merge 1 commit intovagebnd:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a significant improvement to the TypeScript interface generation process from Laravel models and resources. The main change is the addition of namespace grouping, so all generated TypeScript types are now wrapped in appropriate
declare namespaceblocks based on their PHP namespaces. This ensures clearer organization, prevents naming collisions, and improves type references. The pull request also updates formatting and test expectations to reflect these changes.Feature request
This PR is the followup based on the feature request: #14
Namespace Grouping & Type Reference Improvements:
declare namespaceblocks, determined by their PHP class namespaces, both in the generator and in the expected output.Vagebond.Runtype.Tests.Fakes.Resources.ProductResourceType, instead of justProductResourceType.Formatting Enhancements:
Upcoming Enhancements: