fix type export compatibility with node next projects

[rawpixel-vincent]

fix #21

tests pass

it's probably a breaking changes for some projects.

in node 22 using modules

I have to use this to get the proper types:

import * as iovalkey from 'iovalkey';
const IOValkey = iovalkey.default;

// OR

import IOValkey from 'iovalkey';

// new IOValkey() => const IOValkey: new (options: iovalkey.RedisOptions) => Redis (+7 overloads)

haven't tested in commonjs node projects but noticed you support node 18.x so hopefully that still works

[mcollina]

lgtm

Good work! I'll ship asap if CI is green

[mcollina]

Can you fix CI?

[rawpixel-vincent]

ok second iteration.. and ran more test locally with different setup.
I have to do a harmless trick to make the type resolution behave correctly when using different moduleResolution/target in the consumer packages tsconfig.

but then the actual code remains the same.

some notes:

✅ types are happy
✅ import works

import IOValkey from 'iovalkey';

✅ types are happy
✅ import works

import * as iovalkey from 'iovalkey';
const IOValkey = iovalkey.default;

✅ types are happy
✅ import works

import { default as IOValkey } from 'iovalkey';

✅ types are happy
✅ import works with the update that add the named exports

import { Redis as IOValkey } from 'iovalkey';
import { Command } from 'iovalkey';

N.B. without named export (using export default as Redis from redis.js..) => import crash => Named export 'Redis' not found. The requested module 'iovalkey' is a CommonJS module, blablabla. CommonJS modules can always be imported via the default export,..: import pkg from 'iovalkey'; const { Redis } = pkg;

Same for all export named as, that's not compatible with es module.

I don't think there's any breaking changes anymore

[rawpixel-vincent]

Okay I figured I can run the checks in my fork, all green, had to sort some exports order before types exports in index.ts

[rawpixel-vincent]

lgtm

Good work! I'll ship asap if CI is green

Thanks, no rush on my end 👌🏻

[rawpixel-vincent]

btw I just saw that the readme has incorrect instruction, probably a search and replace for Redis

// Import iovalkey.
// You can also use import { Valkey } from "iovalkey"
// if your project is a TypeScript project,
// Note that import Valkey from "iovalkey" is still supported,
// but will be deprecated in the next major version.

there's no named { Valkey } export, I can add that. (in addition to the Redis one to not break existing usage)

and it's there #41

[rawpixel-vincent]

I can put this pr together with #41, #43 and #44 if its preferable, as they are all using this as base.