Update Benchmark topic with latest valkey-benchmark.c changes#441
Open
Andriciuc wants to merge 7 commits into
Open
Update Benchmark topic with latest valkey-benchmark.c changes#441Andriciuc wants to merge 7 commits into
Andriciuc wants to merge 7 commits into
Conversation
This PR focuses on updating the benchmark.md chapter from valkey-io#414 and using the latest updated valkey-benchmark.c file from #2823. First commit changes: - add --duration and --warmup options - move --seed in correct option place - add two examples based on --duration, --warmup and --rps Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
This PR focuses on updating the benchmark.md chapter from valkey-io#414 and using the latest updated valkey-benchmark.c file from #2823. First commit changes: add --duration and --warmup options move --seed in correct option place add two examples based on --duration, --warmup and --rps Replaces valkey-io#435 Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Also remove artifactfor $ valkey-benchmark from docs Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
- Add missing options: --duration, --warmup, --rps, --sequential, --num-functions, --num-keys-in-fcall, --dataset, --maxdocs, --fuzz, --fuzz-mode, --fuzz-loglevel - Add missing placeholders: __rand_1st__ through __rand_9th__, __field:name__ - Fix --rand_int__ description: multiple occurrences per command get different values - Fix -r description: "expand" -> "replace" - Fix --precision default value: 0 -> 3 - Add examples for --warmup/--duration, --rps, and --dataset - Remove C source artifacts from transaction example and keyspace output Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Contributor
Author
|
The following changes have been done to the benchmarking chapter: For Placeholders (Description section):
New options added:
Existing option corrections:
Examples:
Keyspace output block:
|
Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
Signed-off-by: Dragos Andriciuc <andriciucdragos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on updating the benchmark.md chapter from #414 and using the latest updated valkey-benchmark.c file from valkey-io/valkey#2823.
First commit changes:
add --duration and --warmup options
move --seed in correct option place
add two examples based on --duration, --warmup and --rps
Replaces #435