Create video post issue template#509
Open
pnbrown wants to merge 8 commits into
Open
Conversation
Added a template for new video post issues to streamline submissions. Signed-off-by: Nigel Brown <niigel@amazon.com>
Contributor
Author
|
Still need to add the .md file that @stockholmux is requesting in #508 |
Uses blog submission guidelines as framework. Signed-off-by: Nigel Brown <niigel@amazon.com>
minor text fixes Signed-off-by: Nigel Brown <niigel@amazon.com>
Contributor
Author
|
@crystalphamLF What do you think of what's here? Should we add anything else? |
Contributor
|
@pnbrown Can I have a call with you? Would love to learn what you are thinking for this and help make it happen. |
Contributor
Author
|
Sure. We can set up some time tomorrow if you like |
Updated the video template to clarify submission instructions and added a confirmation checkbox for content review. Signed-off-by: Nigel Brown <niigel@amazon.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds a documented lifecycle and a GitHub issue template to formalize community contributions of videos for the Valkey YouTube channel: a new ChangesVideo Contribution Process
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/ISSUE_TEMPLATE/video_template.md:
- Line 4: Update the template title placeholder to reference a video rather than
a blog post: change the title string " [VIDEO POST] <Put your tentative blog
post title here>" so the placeholder text reads something like "[VIDEO POST]
<Put your tentative video post title here>" (locate and edit the title line that
currently contains "<Put your tentative blog post title here>").
- Line 26: Replace the incorrect markdown task-list marker "- []" with the
correct "- [ ]" so the checkbox on the review requirement line becomes
interactive; locate the sentence that currently begins with "- [] **Please check
to confirm..." and update the checkbox syntax to "- [ ]" to render a clickable
GitHub task-list item.
In `@VIDEO_CONTRIBUTION_LIFECYCLE.md`:
- Around line 25-29: The numbered list items "4. Talk about Valkey." and "5.
Have a call-to-action." are broken by unindented continuation lines; fix by
indenting the following lines ("There are a ton of things..." and "What do you
want your viewers...") so they are treated as continued content of items 4 and 5
(e.g., prefix continuation lines with two or four spaces) so the Markdown keeps
them inside their respective numbered bullets.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5f4a4e37-fc74-499a-a695-82119cbb0842
📒 Files selected for processing (2)
.github/ISSUE_TEMPLATE/video_template.mdVIDEO_CONTRIBUTION_LIFECYCLE.md
Signed-off-by: Nigel Brown <niigel@amazon.com>
Signed-off-by: Nigel Brown <niigel@amazon.com>
Consolidate points about discussing Valkey and call-to-action in video contributions. Signed-off-by: Nigel Brown <niigel@amazon.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
VIDEO_CONTRIBUTION_LIFECYCLE.md (1)
20-20: ⚡ Quick winConsider hyphenating "write up" for consistency.
The phrase "write up" should be hyphenated as "write-up" when used as a noun, per standard style guides.
📝 Suggested fix
-1. It may be helpful to create a script, write up, treatment, or description to share with the community before making the video +1. It may be helpful to create a script, write-up, treatment, or description to share with the community before making the video🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@VIDEO_CONTRIBUTION_LIFECYCLE.md` at line 20, Change the noun phrase "write up" to the hyphenated form "write-up" in the sentence "It may be helpful to create a script, write up, treatment, or description to share with the community before making the video" so it reads "script, write-up, treatment, or description"; update the single occurrence in VIDEO_CONTRIBUTION_LIFECYCLE.md accordingly to maintain consistent style.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@VIDEO_CONTRIBUTION_LIFECYCLE.md`:
- Line 26: Fix the grammar in step 5's sentence ("5. Have a call-to-action.
...") by removing the incorrect article: change the phrase "a users" to "users"
so the sentence reads "...asking users to contribute, try some sample code, or
come to an event." Update the line containing "a users" accordingly.
---
Nitpick comments:
In `@VIDEO_CONTRIBUTION_LIFECYCLE.md`:
- Line 20: Change the noun phrase "write up" to the hyphenated form "write-up"
in the sentence "It may be helpful to create a script, write up, treatment, or
description to share with the community before making the video" so it reads
"script, write-up, treatment, or description"; update the single occurrence in
VIDEO_CONTRIBUTION_LIFECYCLE.md accordingly to maintain consistent style.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 27141c48-5aa5-40d3-82bf-426a5f5f1c2f
📒 Files selected for processing (2)
.github/ISSUE_TEMPLATE/video_template.mdVIDEO_CONTRIBUTION_LIFECYCLE.md
✅ Files skipped from review due to trivial changes (1)
- .github/ISSUE_TEMPLATE/video_template.md
| 1. Acceptable Example: A video that describes the lessons learned about operating Valkey at scale gleaned from a Valkey service provider. | ||
| 2. Unacceptable Example: A video that describes the advantages of running Valkey through a specific service. | ||
| 4. Talk about Valkey. There are a ton of things to say about Valkey without venturing into comparisons with other products and projects. | ||
| 5. Have a call-to-action. What do you want your viewers to do next after they finish your video? The call-to-action can be something like asking a users to contribute, try some sample code, or come to an event. You can even just invite viewers to consume related content. |
There was a problem hiding this comment.
Fix grammar error: "a users" should be "users".
Remove the article "a" before the plural noun "users".
📝 Suggested fix
-5. Have a call-to-action. What do you want your viewers to do next after they finish your video? The call-to-action can be something like asking a users to contribute, try some sample code, or come to an event. You can even just invite viewers to consume related content.
+5. Have a call-to-action. What do you want your viewers to do next after they finish your video? The call-to-action can be something like asking users to contribute, try some sample code, or come to an event. You can even just invite viewers to consume related content.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| 5. Have a call-to-action. What do you want your viewers to do next after they finish your video? The call-to-action can be something like asking a users to contribute, try some sample code, or come to an event. You can even just invite viewers to consume related content. | |
| 5. Have a call-to-action. What do you want your viewers to do next after they finish your video? The call-to-action can be something like asking users to contribute, try some sample code, or come to an event. You can even just invite viewers to consume related content. |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@VIDEO_CONTRIBUTION_LIFECYCLE.md` at line 26, Fix the grammar in step 5's
sentence ("5. Have a call-to-action. ...") by removing the incorrect article:
change the phrase "a users" to "users" so the sentence reads "...asking users to
contribute, try some sample code, or come to an event." Update the line
containing "a users" accordingly.
Corrected grammatical error in the call-to-action section. Signed-off-by: Nigel Brown <niigel@amazon.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a template for new video post issues to streamline submissions.
Description
Issues Resolved
related to #508
Check List
--signoffBy submitting this pull request, I confirm that my contribution is made under the terms of the BSD-3-Clause License.
Summary by CodeRabbit