Skip to content

Add valkey-GLIDE PHP client to recommended clients list#557

Draft
adrianluna wants to merge 1 commit into
valkey-io:mainfrom
adrianluna:php/add-valkey-glide-to-clients
Draft

Add valkey-GLIDE PHP client to recommended clients list#557
adrianluna wants to merge 1 commit into
valkey-io:mainfrom
adrianluna:php/add-valkey-glide-to-clients

Conversation

@adrianluna
Copy link
Copy Markdown

@adrianluna adrianluna commented May 23, 2026

Description

Adds the Valkey GLIDE PHP client to the recommended clients list on the clients page.

This is the companion change to valkey-io/valkey-doc#443, which adds the clients/php/valkey-GLIDE.json metadata file. This PR ensures the website renders the new entry by including it in recommended_clients_paths.

Changes

  • Added /php/valkey-GLIDE.json to recommended_clients_paths in
    content/clients/_index.md

Testing

Screenshot 2026-05-22 at 22 17 07

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 23, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f2ba417-f59c-4a26-8d3a-a632c696d819

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adds the Valkey PHP GLIDE client to the recommended clients configuration by extending the recommended_clients_paths list in the clients page frontmatter.

Changes

PHP Valkey GLIDE Client Addition

Layer / File(s) Summary
Add PHP Valkey GLIDE to recommended clients
content/clients/_index.md
The recommended_clients_paths array in the page frontmatter now includes /php/valkey-GLIDE.json, extending the set of Valkey PHP client data sources rendered in the client list.

Comment @coderabbitai help to get the list of available commands and usage tips.

@stockholmux stockholmux marked this pull request as draft May 25, 2026 16:55
@stockholmux
Copy link
Copy Markdown
Member

@adrianluna Thanks for the contribution! I'm excited about GLIDE PHP but would you mind fixing your DCO issue?

I've also swapped this over to draft since it's dependent on another PR so it doesn't get accidentally merged.. Once that is merged, swap it back and make it ready for review.

Signed-off-by: Adrian Luna <adrian.luna.rojas@gmail.com>
@adrianluna adrianluna force-pushed the php/add-valkey-glide-to-clients branch from 9e87a88 to 016eb86 Compare May 25, 2026 22:04
@adrianluna
Copy link
Copy Markdown
Author

@stockholmux Thanks for moving the PR to draft and the link for the DCO issue, I'll put it back in review once the other PR is merged.

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 28, 2026

Greptile Summary

This PR adds the Valkey GLIDE PHP client to the recommended clients list by inserting one entry into recommended_clients_paths in content/clients/_index.md.

  • The new path /php/valkey-GLIDE.json follows the same naming convention as existing GLIDE client entries for Python, Node.js, Java, Go, and C#, and is correctly placed alongside the other PHP clients (phpredis, predis).
  • The change depends on the companion PR (PHP: Add Valkey GLIDE PHP client to clients documentation valkey-doc#443) that adds the actual JSON metadata file; deployment ordering should be confirmed to avoid a missing-file reference at build time.

Confidence Score: 4/5

Safe to merge once the companion valkey-doc PR (#443) that supplies the JSON metadata file is confirmed merged and its data is available to the site builder.

The change is a single-line addition to a TOML array and follows the established naming convention exactly. The only thing to watch is that the JSON metadata file this entry points to must exist when the site is built; without it the build could silently skip or error on the missing reference.

No files require special attention beyond confirming the companion data PR is merged before deploying this change.

Important Files Changed

Filename Overview
content/clients/_index.md Adds /php/valkey-GLIDE.json to recommended_clients_paths; entry is correctly placed alongside other PHP clients and follows the naming convention of existing GLIDE entries for other languages.

Sequence Diagram

sequenceDiagram
    participant Site as valkey-io.github.io (this PR)
    participant Doc as valkey-doc (PR #443)
    participant Builder as Site Builder

    Doc->>Doc: Add clients/php/valkey-GLIDE.json
    Site->>Site: Add /php/valkey-GLIDE.json to recommended_clients_paths
    Builder->>Site: Read _index.md → discover recommended_clients_paths
    Builder->>Doc: Fetch /php/valkey-GLIDE.json
    Doc-->>Builder: Return PHP GLIDE client metadata
    Builder->>Builder: Render PHP client table entry
Loading

Reviews (1): Last reviewed commit: "Add valkey-GLIDE PHP client to recommend..." | Re-trigger Greptile

Comment thread content/clients/_index.md
"/go/valkey-go.json",
"/php/phpredis.json",
"/php/predis.json",
"/php/valkey-GLIDE.json",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Dependency on companion PR must be merged first

This entry references /php/valkey-GLIDE.json, which is added in the companion PR valkey-io/valkey-doc#443. If this website PR is merged and deployed before the metadata file lands in the valkey-doc repo (and that repo's data is synced/published), the site builder may silently skip or error on the missing JSON file. Please ensure the data PR is merged and the doc data is available before this change goes live.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants