Feature: Add optimized constructors to PoolConfigs for easier performance tuning#25
Open
sonii-shivansh wants to merge 1 commit intovalkey-io:masterfrom
Open
Conversation
Signed-off-by: Shivansh Soni <s.soni.shivansh@gmail.com>
ba31f54 to
039c5da
Compare
Collaborator
|
@sonii-shivansh Hi, thank you for this PR. However, we cannot merge it because this configuration is suitable for most scenarios, but not all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Performance-Optimized Constructor for Pool Configurations
Adds a new constructor to
JedisPoolConfigandConnectionPoolConfigthat automatically applies the recommended performance ratio:maxTotal = maxIdle = 2 * minIdle.The README recommends setting
maxTotal = maxIdle = 2 * minIdlefor best performance, but users must calculate these values manually. This enhancement makes it easier to follow best practices.Changes
JedisPoolConfig(int minIdle)constructor with performance defaultsConnectionPoolConfig(int minIdle)constructor with performance defaultsmaxIdleandmaxTotalto2 * minIdleUsage
Before:
After:
Testing