Support running integration tests against an external Valkey server#102
Open
enjoy-binbin wants to merge 2 commits into
Open
Support running integration tests against an external Valkey server#102enjoy-binbin wants to merge 2 commits into
enjoy-binbin wants to merge 2 commits into
Conversation
In valkey-io#70, we modified the Python code to support it, but some content was missing. - README: document the VALKEY_EXTERNAL_SERVER / VALKEY_HOST / VALKEY_PORT environment variables for running integration tests against an already-running Valkey server with module loaded. - tst/integration/run.sh: drop the "Kill old running test" pkill block so it does not terminate the user-managed external valkey-server before tests start. - CMakeLists.txt: bump VALKEY_TEST_FRAMEWORK_COMMIT from a pinned hash to "unstable" to pull in the external-server support that is not available in the previously pinned commit. Signed-off-by: Binbin <binloveplay1314@qq.com>
roshkhatri
reviewed
Jun 4, 2026
Co-authored-by: Roshan Khatri <117414976+roshkhatri@users.noreply.github.com> Signed-off-by: Binbin <binloveplay1314@qq.com>
Member
Author
Yes, that would be great if we have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #70, we modified the Python code to support it, but some content was
missing.
README: document the VALKEY_EXTERNAL_SERVER / VALKEY_HOST / VALKEY_PORT
environment variables for running integration tests against an
already-running Valkey server with module loaded.
tst/integration/run.sh: drop the "Kill old running test" pkill block
so it does not terminate the user-managed external valkey-server
before tests start.
CMakeLists.txt: bump VALKEY_TEST_FRAMEWORK_COMMIT from a pinned hash
to "unstable" to pull in the external-server support that is not
available in the previously pinned commit.