Support reusing externally built valkey-server and valkeymodule.h for test#103
Open
enjoy-binbin wants to merge 3 commits into
Open
Support reusing externally built valkey-server and valkeymodule.h for test#103enjoy-binbin wants to merge 3 commits into
enjoy-binbin wants to merge 3 commits into
Conversation
Add VALKEY_SERVER_PATH to skip building Valkey from source and copy the provided binary into the integration test directory instead. The Valkey source is still downloaded (without being built) so that valkeymodule.h is available for module compilation. Signed-off-by: Binbin <binloveplay1314@qq.com>
roshkhatri
reviewed
Jun 4, 2026
Comment on lines
+52
to
+56
| To skip building Valkey from source and reuse an externally built `valkey-server` binary, set `VALKEY_SERVER_PATH` to its absolute path. | ||
| The binary will be copied into the integration test directory; `valkeymodule.h` is still fetched from the Valkey repo for compiling the module: | ||
| ```text | ||
| SERVER_VERSION=unstable VALKEY_SERVER_PATH=/path/to/valkey-server ./build.sh --integration | ||
| ``` |
Member
There was a problem hiding this comment.
I think we can also add a path to valkeymodule.h? so you can match the version of valkey you built and the valkeymodule.h version? with this we would also be able to build it offilne?
Member
Author
There was a problem hiding this comment.
Yes, good call out, added valkeymodule.h
Allow supplying a local valkeymodule.h via VALKEY_MODULE_H_PATH so header and valkey-server versions can be matched. When combined with VALKEY_SERVER_PATH, the Valkey repo is no longer cloned at all, enabling fully offline builds. Signed-off-by: Binbin <binloveplay1314@qq.com>
enjoy-binbin
changed the title
Signed-off-by: Binbin <binloveplay1314@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add VALKEY_SERVER_PATH and VALKEY_MODULE_H_PATH options to skip
building Valkey from source for integration tests:
the integration test directory instead of building it.
fetching it from the cloned Valkey repo, so the header version can
match the binary version.
builds), the Valkey repo is no longer cloned at all, enabling fully
offline builds.