Skip to content

Add .clang-format and .clang-tidy#78

Open
cxljs wants to merge 3 commits into
valkey-io:unstablefrom
cxljs:clang-tidy
Open

Add .clang-format and .clang-tidy#78
cxljs wants to merge 3 commits into
valkey-io:unstablefrom
cxljs:clang-tidy

Conversation

@cxljs
Copy link
Copy Markdown
Member

@cxljs cxljs commented Aug 23, 2025

refs: #75

@roshkhatri
Copy link
Copy Markdown
Member

roshkhatri commented Aug 25, 2025

Hey, Thank you for working on this, Can you also add a workflow for this check on very push and pull req?
Similar implementation can be found here in valkey: https://github.com/valkey-io/valkey/blob/unstable/.github/workflows/clang-format.yml:

Do we also want to use this: https://github.com/valkey-io/valkey-json/blob/unstable/src/json/CPPLINT.cfg?

@cxljs
Copy link
Copy Markdown
Member Author

cxljs commented Aug 26, 2025

Can you also add a workflow for this check on very push and pull req?

Yes, I will finish it later.

Do we also want to use this: https://github.com/valkey-io/valkey-json/blob/unstable/src/json/CPPLINT.cfg?

I was concerned that you might need the cpplint.cfg file, so I kept it. If you don't need it, I'll remove it later.

cxljs added 2 commits August 26, 2025 21:26
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
@roshkhatri
Copy link
Copy Markdown
Member

Okay will wait and review again when wfs are added.

Comment thread src/json/alloc.h
#define VALKEYJSONMODULE_ALLOC_H_

#include <stddef.h>
#include <cstddef>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Contributor

@sarthakaggarwal97 sarthakaggarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It took me some time to get back to this, sorry about that. The changes looks mostly good to me. @cxljs are you looking into adding a new workflow?

@Nikhil-Manglore
Copy link
Copy Markdown
Member

Tagging @cxljs in case they missed the previous notifications 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants