Add .clang-format and .clang-tidy#78
Conversation
|
Hey, Thank you for working on this, Can you also add a workflow for this check on very push and pull req? Do we also want to use this: https://github.com/valkey-io/valkey-json/blob/unstable/src/json/CPPLINT.cfg? |
Yes, I will finish it later.
I was concerned that you might need the cpplint.cfg file, so I kept it. If you don't need it, I'll remove it later. |
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
Signed-off-by: Xiaolong Chen <fukua95@gmail.com>
|
Okay will wait and review again when wfs are added. |
| #define VALKEYJSONMODULE_ALLOC_H_ | ||
|
|
||
| #include <stddef.h> | ||
| #include <cstddef> |
sarthakaggarwal97
left a comment
There was a problem hiding this comment.
It took me some time to get back to this, sorry about that. The changes looks mostly good to me. @cxljs are you looking into adding a new workflow?
|
Tagging @cxljs in case they missed the previous notifications 😄 |
refs: #75