Update field cache to allow it to be used wihtout the query_name#6
Open
zacscott wants to merge 3 commits intovalu-digital:masterfrom
Open
Update field cache to allow it to be used wihtout the query_name#6zacscott wants to merge 3 commits intovalu-digital:masterfrom
zacscott wants to merge 3 commits intovalu-digital:masterfrom
Conversation
Contributor
|
Doesn't |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update field caching to work across multiple queries.
This PR allows a field cache to be configured across multiple / all queries. When the
query_nameparameter is omitted, a field cache will be global and not tied to a specific query at all.This is useful for caching fields which are included across multiple queries. An example from a project I am working on is the menus, which are included in every query we do. I can configure a field cache like so and have it computed on once globally for all of our queries.
E.g.
This is still compatible with fields configured with a
query_nameand will function exactly as it does currently.