ci(deps): Bump actions/upload-artifact from 4 to 7#2
Closed
dependabot[bot] wants to merge 13 commits into
Closed
Conversation
ResNet-50 + BNNeck strong baseline (Luo et al., "Bag of Tricks") implemented as a clean, installable `reid` package: - Data: Market-1501 dataset, identity-balanced PK sampler, transforms. - Model: ResNet-50 backbone, GeM pooling, last_stride=1, BNNeck head. - Losses: label-smoothed cross-entropy, batch-hard/soft-margin triplet, optional center loss, combined ReIDLoss. - Engine: Trainer with AMP, LR warmup (multistep/cosine), best-by-mAP ckpt. - Eval: cached features, flip-TTA, L2-normalized cosine retrieval, CMC/mAP, k-reciprocal re-ranking. - Tooling: typed YAML config, pytest suite, ruff, mypy, GitHub Actions CI, Docker, pre-commit, Gradio demo, visualizations. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Adopt the Contributor Covenant 2.1 (resolving the broken link from CONTRIBUTING.md) and add SECURITY.md with private vulnerability-reporting channels and deployment safety notes. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Compute the epoch length once at construction as the number of complete PK batches times the batch size, and stop mutating self.length inside __iter__. Previously len(sampler) was an upper-bound estimate that changed after the first iteration, so len(dataloader) was wrong on epoch 0 and inconsistent thereafter. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add pure-CPU unit tests for the previously-untested engine schedulers (warmup endpoints, milestone decay, cosine annealing, factory dispatch), checkpoint save/load round-trips and classifier-size inference, device CPU-fallback, and the results-table renderer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add CI/license/Python/PyTorch/ruff badges and a Results table (reference strong-baseline figures with placeholders for measured numbers). Add notebooks/train_colab.ipynb for one-click GPU reproduction, linked from the README. Fix the stale 'make install' comment and record the changes in CHANGELOG. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace the brittle clone+install cells with one setup cell that locates the project root (or clones it), installs the package, and puts src/ on sys.path and PYTHONPATH so 'import reid' resolves in both the kernel and the !python subprocesses. Prevents ModuleNotFoundError: No module named 'reid' when the package isn't installed or the code lives outside the repo root. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace ghcr.io/astral-sh/uv:latest (which contradicted the 'pinned' comment) with an exact version (0.11.21) for reproducible image builds, and add a HEALTHCHECK that verifies the Gradio server answers on port 7860. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Run 'uv build' and install the resulting wheel into a clean venv, verifying 'import reid' works from the packaged distribution (guards the src-layout packaging and console-script entry points) and uploading the sdist/wheel as artifacts. Verified locally that the wheel ships both reid/ and scripts/. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Trainer._run_evaluation reused the Evaluator's cached query/gallery features (Evaluator._ensure_features early-returns on the cache), so every periodic eval after the first computed mAP against the FIRST epoch's features. mAP stayed frozen and best-by-mAP locked best.pth to the earliest evaluated epoch. Reset the cache before each in-loop eval so metrics reflect the current weights and best.pth tracks the true best epoch. Found by the pre-training correctness audit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…audit) camid regex uses \d+ (future-proof beyond nine cameras; identical on Market-1501); DataLoader pin_memory is derived from torch.cuda.is_available() instead of hardcoded True; the Gradio demo skips unreadable gallery images and gains an optional --auth flag with an off-loopback warning. All non-result-affecting hardening from the audit. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
len(sampler) is now a construction-time estimate (the __len__ mutation was removed), so it is not the exact yielded count: under random identity selection the sampler can strand a few groups, making the yield <= len(sampler). The old 'len(sampler) == len(indices)' assertion relied on the removed mutation and was flaky across RNG states (only surfaced in the full suite). Assert the real invariant instead. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Rebrand from person-reid-market1501 across the distribution name, GitHub URLs (README badges, project URLs, CITATION, Colab link), Docker image name, Makefile, and docs. The import package (reid) and all behavior are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@v4...v7) --- updated-dependencies: - dependency-name: actions/upload-artifact dependency-version: '7' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Author
LabelsThe following labels could not be found: Please fix the above issues or remove invalid values from |
Author
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
dependabot
Bot
deleted the
dependabot/github_actions/actions/upload-artifact-7
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps actions/upload-artifact from 4 to 7.
Release notes
Sourced from actions/upload-artifact's releases.
... (truncated)
Commits
043fb46Merge pull request #797 from actions/yacaovsnc/update-dependency634250cInclude changes in typespec/ts-http-runtime 0.3.5e454baaReadme: bump all the example versions to v7 (#796)74fad66Update the readme with direct upload details (#795)bbbca2dSupport direct file uploads (#764)589182cUpgrade the module to ESM and bump dependencies (#762)47309c9Merge pull request #754 from actions/Link-/add-proxy-integration-tests02a8460Add proxy integration testb7c566aMerge pull request #745 from actions/upload-artifact-v6-releasee516bc8docs: correct description of Node.js 24 support in READMEDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)