feat(reflect): make source facts in search_observations configurable#688
Merged
nicoloboschi merged 3 commits intomainfrom Mar 25, 2026
Merged
feat(reflect): make source facts in search_observations configurable#688nicoloboschi merged 3 commits intomainfrom
nicoloboschi merged 3 commits intomainfrom
Conversation
The recent fix (#669) hardcoded include_source_facts=False in search_observations to prevent context overflow. This makes it configurable via HINDSIGHT_API_REFLECT_SOURCE_FACTS_MAX_TOKENS (env/tenant/bank), defaulting to -1 (disabled). - -1: source facts disabled (current behavior, default) - 0: source facts enabled with no token limit - >0: source facts enabled with a token budget
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
include_source_facts=Falseinsearch_observationsto prevent context overflow during reflect. This makes it configurable viaHINDSIGHT_API_REFLECT_SOURCE_FACTS_MAX_TOKENS(env/tenant/bank hierarchical config), defaulting to-1(disabled, preserving current behavior).-1= disabled (default),0= enabled unlimited,>0= enabled with token budgetTest plan
tool_search_observationswith all three modes (-1, 0, >0)