fix: control plane UI fixes for recall and data view#692
Closed
nicoloboschi wants to merge 4 commits intomainfrom
Closed
fix: control plane UI fixes for recall and data view#692nicoloboschi wants to merge 4 commits intomainfrom
nicoloboschi wants to merge 4 commits intomainfrom
Conversation
Metadata stored during retain was never retrieved during recall. Add metadata to all SQL SELECT queries, the RetrievalResult dataclass, ScoredResult.to_dict(), and MemoryFact construction in the recall pipeline.
Replace placeholder metadata test with one that actually passes metadata via retain_batch_async and asserts it is returned on recall.
asyncpg may return JSONB columns as strings. Add a field_validator to MemoryFact.metadata to handle JSON string deserialization.
- Sanitize NaN cross-encoder scores to 0.0 in reranking pipeline (Pydantic serializes NaN as JSON null, breaking UI score display) - Add null-coalesce for score in search debug view to prevent crash - Switch data view text filter from debounced onChange to Enter key (avoids slow ILIKE queries on every keystroke for large banks) - Show loading spinner in search icon during filter requests - Preserve search/tag filters when clicking "Load more"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
null, crashing the search debug view (score.toFixed(3)on null). Fixed by sanitizing NaN to 0.0 in the reranking pipeline and adding a null-coalesce in the UI.Test plan