fix(claude-code): make fcntl import conditional for Windows compatibility#694
Merged
nicoloboschi merged 1 commit intomainfrom Mar 25, 2026
Merged
fix(claude-code): make fcntl import conditional for Windows compatibility#694nicoloboschi merged 1 commit intomainfrom
nicoloboschi merged 1 commit intomainfrom
Conversation
…lity fcntl is a Unix-only module — importing it unconditionally causes an ImportError on Windows, breaking the entire plugin. Guard the import with a sys.platform check and fall back to a no-op lock path in increment_turn_count() so Windows users get correct behaviour without crashing.
nicoloboschi
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fcntlis a Unix-only module — importing it unconditionally causes anImportErroron Windows, crashing the entire plugin at startupsys.platform != "win32"and setsfcntl = Noneon Windowsincrement_turn_count()now skips the flock path whenfcntl is None, falling back directly to the lockless read-modify-write (the same fallback that already existed forOSError)Test plan
python -c "from lib.state import increment_turn_count")🤖 Generated with Claude Code