Skip to content

Improve RGB LED functionality#76

Merged
vedderb merged 5 commits intovedderb:mainfrom
techfoundrynz:feat/rgbled-multipin-reliability
Apr 9, 2026
Merged

Improve RGB LED functionality#76
vedderb merged 5 commits intovedderb:mainfrom
techfoundrynz:feat/rgbled-multipin-reliability

Conversation

@techfoundrynz
Copy link
Copy Markdown
Contributor

  1. Add wait to led update to prevent partial strip updates
  2. Pull old pin low when calling init with different pin to avoid floating/high state potentially causing flickering leds on multi-pin setups

Maintains compatibility with any existing lisp scripts

Add wait to led update to prevent partial strip updates
Pull old pin low when calling init with different pin to avoid floating/high state potentially causing
Comment thread main/rgbled/lispif_rgbled_extensions.c Outdated
Comment thread main/rgbled/lispif_rgbled_extensions.c Outdated
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to get rid of this argument and led_type_driver. They are not used since I moved the RGB order into the LED buffer.

@vedderb
Copy link
Copy Markdown
Owner

vedderb commented Feb 26, 2026

I'm happy to merge this one if it works well for you. At the moment I don't have any setup with RGB LEDs and it looks like you have more experience with them than I do.

@techfoundrynz
Copy link
Copy Markdown
Contributor Author

I'm happy to merge this one if it works well for you. At the moment I don't have any setup with RGB LEDs and it looks like you have more experience with them than I do.

Thanks, appreciate it. I'm going to do some more a/b tests with large strips on multiple pins over the weekend and will publish the PR once I'm happy with the results.

@vedderb
Copy link
Copy Markdown
Owner

vedderb commented Mar 11, 2026

Any update on this one? The changes look very useful and I'm happy to test and merge them.

@TheZeroBeast
Copy link
Copy Markdown

Looks good here, I'll try test a build with it.

@TheZeroBeast
Copy link
Copy Markdown

I've compiled and tested this and it's working as expected. Might help get some good code vetted for the masses :)

@vedderb
Copy link
Copy Markdown
Owner

vedderb commented Apr 8, 2026

@techfoundrynz any update? I'm happy to merge this one.

@techfoundrynz techfoundrynz marked this pull request as ready for review April 9, 2026 04:19
@vedderb vedderb merged commit 50d323c into vedderb:main Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants