Conversation
|
Hi, sorry I do not understand what you are missing. Can you please provide your device type? |
|
Hello veista and thanks for looking into my PR! Was i able to explain myself better now? |
|
maybe when you look at the registers i used to create that plot it becomes more clear. |
|
|
||
| central_heat_heat_ext_set = 1800 | ||
|
|
||
| hps_input_t17_supply = 1900 |
There was a problem hiding this comment.
Why would you edit the register map? These are pretty much 1:1 to Nilan documentation.
I understand that you are missing some features or some features do not work for you as intended. You have renamed everything everywhere so I get confused what it was you were trying to do, sorry. |

Hello Veista,
i was unable to find some temperatures from the HPS or GEO part of my CompactP2/Geo3, especially i was interested in the ones you see on the pictures from the Compact Remote Control called "T13 Vorlauf Sole" (hps brine input) and "T14 Rücklauf Sole" (hps brine return). It was pretty hard to find the registers for it but after trying mayn different ones i finally found them. They are a bit weired compared to the others as they are so different. But when you look at the attached plot, you can see, that they actually produce reasonable values, when i switch on the Geo part. This pull request is not meant to be merged as is, its just, what currently works for me. Would be great, if you can take a look at it and then we can discuss, how we can exactly put it in, if possible at all.
Regarding T16 and T17 on my remote control display i wasn't sure, how to deal with those because they were already available but the code was a bit unclear to me so i changed the implementation as well but that can be removed.
Just tell me how you like to have it and i will adopt.