fix(ci): kill the vault-core registry shadow permanently — bump core past the frozen registry#378
Merged
Merged
Conversation
…past the frozen registry
CI failed 44 tests on main ('no such table: wikilink_suppression_overrides'):
PR #377 added the v43 schema to the WORKSPACE core, but npm ci resolved
@velvetmonkey/vault-core@^2.12.12 to the REGISTRY 2.12.13 (frozen — npm
publish retired 2026-06-06) and nested it under packages/mcp-server/
node_modules, shadowing the workspace copy. New code queried a table its
shadowed runtime didn't have. deploy-local.sh purges the shadow, CI didn't.
Durable fix: core 2.12.12 → 2.12.16, mcp-server dep ^2.12.16. The registry
can never satisfy >2.12.13 again, so npm MUST link the workspace — lockfile
now resolves vault-core to packages/core (link:true) and the nested copy is
gone. This kills the shadow class everywhere, not just where we purge.
mutations + suppression-override suites (the 44): 84/84 locally.
…pm paths npm publish is retired (registry frozen at 2.12.13) and the skill installer pointed at it. README install section now: clone, npm ci, build, point MCP config at dist/index.js (mirrors docs/local-deploy.md). SETUP/CONFIGURATION client blocks (Claude Code / Codex / Claude Desktop / HTTP) all moved off npx to node+dist; npm badge dropped; Windows notes updated (full path to node instead of cmd /c npx).
…rtup smoke, benchmark path + ceilings, local-deploy TOC Main CI has been red since 2026-05-29 with stacked causes. With the vault-core shadow killed (previous commit), the remainder: - backup.test: #377 added wikilink_suppression_overrides to SALVAGE_TABLES without a fixture row — every-table assertion saw undefined. Fixture added. - package-startup: packed only the mcp-server tarball; npm then tried the registry for vault-core@^2.12.16 which can never exist (publish retired). Now packs the WORKSPACE core too and installs both tarballs — the honest smoke for the git-clone distribution model. - graph.benchmark: relative path was one ../ short, pointing at packages/demos/ (a junk dir of stale state DBs that masked the bug locally; CI got ENOENT). Fixed to the real demos/artemis-rocket (66 notes) — which exposed that its token ceilings had been calibrated against an EMPTY vault; recalibrated against real data with headroom (500→2000, 1000→3000) so they're tripwires, not pins. - local-deploy.md: curated TOC added (toc-completeness gate). All four suites green locally.
chmod(0o000) is a no-op under Windows ACLs — the locked file stays readable, the abort-on-empty guard correctly doesn't trip, and the rejects assertion fails. The guard itself is platform-independent; only the unreadability simulation is POSIX-bound.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI failed 44 tests on main ('no such table: wikilink_suppression_overrides'):
PR #377 added the v43 schema to the WORKSPACE core, but npm ci resolved
@velvetmonkey/vault-core@^2.12.12 to the REGISTRY 2.12.13 (frozen — npm
publish retired 2026-06-06) and nested it under packages/mcp-server/
node_modules, shadowing the workspace copy. New code queried a table its
shadowed runtime didn't have. deploy-local.sh purges the shadow, CI didn't.
Durable fix: core 2.12.12 → 2.12.16, mcp-server dep ^2.12.16. The registry
can never satisfy >2.12.13 again, so npm MUST link the workspace — lockfile
now resolves vault-core to packages/core (link:true) and the nested copy is
gone. This kills the shadow class everywhere, not just where we purge.
mutations + suppression-override suites (the 44): 84/84 locally.