Closed
Conversation
Member
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for edge-ssr.jsDiff too large to display |
Adds indirection when trying to find a failing test or focusing on one.
e843b22 to
4dfd98f
Compare
huozhi
reviewed
Apr 30, 2024
|
|
||
| import { join } from 'path' | ||
|
|
||
| import cheerio from 'cheerio' |
Member
There was a problem hiding this comment.
Maybe we can make it a e2e test and specify the version? And we can test both 18 and 19 beta?
Member
Author
There was a problem hiding this comment.
Are we planning to support 18 and 19 in Next.js?
timneutkens
requested changes
Apr 30, 2024
Member
timneutkens
left a comment
There was a problem hiding this comment.
Maybe migrate these to test/e2e and use nextTestSetup to isolate them?
Member
Author
|
Do we have a project that's tracking that instead? I'm trying to land the React sync and don't want to get side-tracked in big refactoring projects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... and move it to
react-current-versionin preparation of #65058If you want to split tests, create a separate .test file so that it's easy to find where a (failing) test is located.
There's more wrong with this test with regard to cleanup but I'm not digging into that now.
Closes NEXT-3262