Skip to content

fix: lock semantic-release publish dependencies#590

Merged
styfle merged 3 commits into
mainfrom
styfle-ai/publish-semantic-release-lockfile-c165
May 27, 2026
Merged

fix: lock semantic-release publish dependencies#590
styfle merged 3 commits into
mainfrom
styfle-ai/publish-semantic-release-lockfile-c165

Conversation

@styfle
Copy link
Copy Markdown
Member

@styfle styfle commented May 27, 2026

We have a problem where semantic-release is only called in ci.yml but it doesnt have a lockfile which means transitive dependencies could change.

I think the reason it was set up this way is to avoid slowing down CI for PRs that don't publish since they wont need to install semantic-release (40MB). Only main needs to publish.

The fix is to add a new publish directory with its own lock file, then we can install and invoke the bin from the publish directory to ensure dependencies are locked.

Co-authored-by: Steven <styfle@users.noreply.github.com>
@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 27, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addednpm/​semantic-release@​25.0.39710010091100

View full report

Comment thread .github/workflows/ci.yml Outdated
Comment thread .github/workflows/ci.yml Outdated
Co-authored-by: Steven <steven@ceriously.com>
@styfle styfle marked this pull request as ready for review May 27, 2026 21:06
@styfle styfle requested review from a team, icyJoseph and ijjk as code owners May 27, 2026 21:06
@styfle styfle requested a review from samcx May 27, 2026 21:15
@styfle styfle changed the title chore: lock semantic-release publish dependencies fix: lock semantic-release publish dependencies May 27, 2026
@styfle styfle enabled auto-merge (squash) May 27, 2026 23:28
@styfle styfle merged commit 0ceef3f into main May 27, 2026
37 of 39 checks passed
@styfle styfle deleted the styfle-ai/publish-semantic-release-lockfile-c165 branch May 27, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants