feat(ARC-3770): add search param to get themes endpoint, fix tests#704
Merged
Conversation
reunefe
approved these changes
Jul 13, 2026
| app_material_requests( | ||
| where: { | ||
| status: { _eq: APPROVED } | ||
| _or: [ |
Contributor
There was a problem hiding this comment.
Hoe is dit erin geraakt? 🤔
Contributor
Author
There was a problem hiding this comment.
gelieve shift click op rijen te gebruiken in github anders zie ik dit:
die comments """ zijn geldige graphql comments, maar onze type generation script kan daar niet mee overweg. dus ik heb ze terug gewist
| const direction = (orderDirection ?? SortDirectionWithRandom.asc) as unknown as Order_By; | ||
| const orderBy = [set({}, dbProp, direction)]; | ||
|
|
||
| if (searchPattern) { |
Contributor
There was a problem hiding this comment.
Niets ophalen als er geen searchTerm wordt opgegeven?
Contributor
Author
There was a problem hiding this comment.
nee, de else zit in de rest van de functie:
hetarchief-proxy/src/modules/themes/services/themes.service.ts
Lines 106 to 118 in b45e8e2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://meemoo.atlassian.net/browse/ARC-3770