Implement logging, update gitignore, fix example filenames#2
Open
mitjasai wants to merge 10 commits into
Open
Conversation
Subprocess stdio file objects are opened in binary mode by default. Setting 'text=True' avoids having to manually decode the outputs for manipulating them as string objects.
This is in line with the previous solution of calling
`decode("utf-8", "replace")` on the IO streams.
The filename of the `osu-intra-node-gcd2gcd-bw` test is `osu-inter-node-gcd2gcd.yaml` and vice versa. Rename the files so that the filenames match the names given in the file contents.
Log job stdout and stderr to a file for debugging.
Since commit 2330bd1 implements logging of stdout and stderr by default, the `--verbose` option is no longer useful.
Create one directory for the IO logs of a single run, and write the logs of all jobs in that directory.
Print argv as a list instead of joining the elements. This helps with debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement stdio logging
Stdout and stderr are now logged under the output directory for every run (default
out/).--verboseflag removed as redundant.Update gitignore
Untrack directories created by running the examples according to the readme.
Fix example filenames
Fix OSU benchmarks' filenames being the wrong way round.