[spark-compete] fix: remove internal module paths from CLI output and status notes#1427
Open
Esc1200 wants to merge 1 commit into
Open
[spark-compete] fix: remove internal module paths from CLI output and status notes#1427Esc1200 wants to merge 1 commit into
Esc1200 wants to merge 1 commit into
Conversation
Replaced leaked filesystem paths with module names only in: - configure_telegram_profile: profile env path (line 4212) - initialize_builder_runtime_home: researcher, memory, voice, and Graphiti sidecar status notes (lines 4291, 4301, 4316, 4328) - cmd_list: list output column (line 4600) - install_modules: install confirmation message (line 5073) These paths could expose internal directory structure to users and should not appear in CLI output.
Esc1200
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
spark-compete-hotfix-v1 packet
team: drophub_sir (esc1200, drophub_sir, spark-agent)
pr_author: Esc1200
repo: vibeforge1111/spark-cli
actual_behavior
cli.py lines 4212, 4291, 4301, 4316, 4328 leak internal module filesystem paths in gateway status notes (e.g., "connected spark-researcher at {researcher.path}", "activated domain-chip-memory at {memory.path}"). Lines 4600 and 5073 leak module paths in list output and install output.
expected_behavior
CLI output should show module names only, not internal filesystem paths. Status notes should not include the "at {path}" suffix.
repro_steps
spark setupto configure gateway modules.spark listand observe the last tab-separated column contains full filesystem paths.spark install <module>and observe "Installed {name} from /path/to/module" output.before_after_proof
Before: 7 locations in cli.py interpolate internal filesystem paths into user-visible output.
After: All 7 locations replaced with module name only. Line 4212 prints "Profile env: {gateway} (profile {profile})". Lines 4291, 4301, 4316, 4328 drop the "at {path}" suffix. Line 4600 uses module.name instead of module.path. Line 5073 prints "Installed {module.name}" without "from {path}".
tests_or_smoke
Verified via git diff that all 7 leaking print/format statements no longer interpolate filesystem paths. Python syntax check passed on modified file.
review_claim
duplicate_notes: No prior PRs address this specific set of 7 path leaks in gateway status notes, list output, and install output.
risk_notes: Low risk. Replacing interpolated path values with module name strings is a safe, backwards-compatible change.