Skip to content

fix(cli): preserve uninstall feedback when a named target hits empty registry #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
4gjnbzb4zf-sudo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(cli): preserve uninstall feedback when a named target hits empty registry #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/spark_cli/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15869,13 +15869,19 @@ def cmd_uninstall(args: argparse.Namespace) -> int:
failures += cmd_autostart_uninstall(argparse.Namespace())

if not modules:
print("No installed Spark modules recorded.")
named_target = args.target if not getattr(args, "all", False) else None
if named_target:
print(f"Unknown installed module: {named_target}. No modules are installed; run `spark install` first.")
else:
print("No installed Spark modules recorded.")
if getattr(args, "remove_user_path", False):
removed = remove_spark_bin_from_windows_user_path()
print("Removed Spark bin from Windows user PATH." if removed else "Spark bin was not present in Windows user PATH.")
if getattr(args, "purge_home", False):
removed_home = purge_spark_home()
print(f"Removed Spark home: {SPARK_HOME}" if removed_home else f"Spark home was not present: {SPARK_HOME}")
if named_target:
return 1
return 1 if failures else 0
removed_names: list[str] = []
for module in modules:
Expand Down
Loading